Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-14 Thread Rémi Denis-Courmont
Le 13 décembre 2023 12:03:55 GMT+02:00, Nicolas George a écrit : >Rémi Denis-Courmont (12023-12-12): >> ...and test for overflow errors in errno.m (which shall have been >> zeroed beforehand). AFAIK, you need to do both if you want strict >> error detection. > >Or we can consider that

Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-13 Thread Nicolas George
Rémi Denis-Courmont (12023-12-12): > ...and test for overflow errors in errno.m (which shall have been > zeroed beforehand). AFAIK, you need to do both if you want strict > error detection. Or we can consider that 30064771114 is just another valid way if writing 42 = 042 = 0x2a. It would be

Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-12 Thread Rémi Denis-Courmont
Le 12 décembre 2023 16:07:28 GMT+02:00, Nicolas George a écrit : >Lena via ffmpeg-devel (12023-12-12): >> The documentation for `strtol` says that on error, 0 is returned. This >> makes it impossible to specify a window handle of 0 (the whole >> desktop), but that case is already covered by

Re: [FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-12 Thread Nicolas George
Lena via ffmpeg-devel (12023-12-12): > The documentation for `strtol` says that on error, 0 is returned. This > makes it impossible to specify a window handle of 0 (the whole > desktop), but that case is already covered by the "desktop" input > filename, so it should be fine. The correct way to

[FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-12 Thread Lena via ffmpeg-devel
Added the change to the documentation and added error checking on `strtol`, according to the stdlib documentation. The documentation for `strtol` says that on error, 0 is returned. This makes it impossible to specify a window handle of 0 (the whole desktop), but that case is already covered by