Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-13 Thread Hamza Shahid
Hi Will, I think we addressed all the review comments in this patch. Which are as follows: 1. Remove inline asm for color conversion and replace with swscale, which I did. 2. Replace static variables with #defines, which I did. 3. Remove unnecessary stuff from configure script, which I did. 4. Us

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-12 Thread Hendrik Leppkes
On Tue, Jan 12, 2016 at 9:26 PM, compn wrote: > On Tue, 12 Jan 2016 10:44:18 -0600 > Will Kelleher wrote: > >> That said, it doesn't look like any of the previous review comments >> (which I agree with) were addressed in this second version. Let me >> know if there is anything I can do to help.

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-12 Thread compn
On Tue, 12 Jan 2016 10:44:18 -0600 Will Kelleher wrote: > That said, it doesn't look like any of the previous review comments > (which I agree with) were addressed in this second version. Let me > know if there is anything I can do to help. some devs made comments that it cannot use colorspace

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-12 Thread Will Kelleher
On 01/12, Hamza Shahid wrote: > Hi Will, > > I think we addressed all the review comments in this patch. Which are as > follows: > > 1. Remove inline asm for color conversion and replace with swscale, which I > did. > 2. Replace static variables with #defines, which I did. > 3. Remove unnecessary

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-12 Thread Will Kelleher
On 01/09, ha...@mayartech.com wrote: > From: "ha...@mayartech.com" > > This commit adds a hardware accelerated H.264 encoder which utilizes > libVA (open source implementation of VA-API). Information about libva > is available at: https://en.wikipedia.org/wiki/Video_Acceleration_API > This encode

[FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-09 Thread hamza
From: "ha...@mayartech.com" This commit adds a hardware accelerated H.264 encoder which utilizes libVA (open source implementation of VA-API). Information about libva is available at: https://en.wikipedia.org/wiki/Video_Acceleration_API This encoder is only availbale on linux and supported hardwa