Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Martin Storsjö
On Thu, 21 May 2020, Michael Niedermayer wrote: On Wed, May 20, 2020 at 09:10:21AM +0300, Martin Storsjö wrote: Sticking a full frame in the extradata works, as the code for writing the avcC/hvcC extracts the relevant parameter set NAL units - provided that they actually exist in the frame.

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Martin Storsjö
On Thu, 21 May 2020, Jan Ekström wrote: On Thu, May 21, 2020 at 2:00 PM Martin Storsjö wrote: Oh, indeed, you're right. However wrong that is from the mov/mp4 point of view, it may very well be that AVC intra is supposed to be written like this in mov/mp4 files - but we'd need a word from

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Jan Ekström
On Thu, May 21, 2020 at 2:00 PM Martin Storsjö wrote: > > Oh, indeed, you're right. > > However wrong that is from the mov/mp4 point of view, it may very well be > that AVC intra is supposed to be written like this in mov/mp4 files - but > we'd need a word from somebody who actually knows that

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Martin Storsjö
On Thu, 21 May 2020, Andreas Rheinhardt wrote: Martin Storsjö: On Thu, 21 May 2020, Andreas Rheinhardt wrote: Martin Storsjö: On Thu, 21 May 2020, Michael Niedermayer wrote: On Wed, May 20, 2020 at 09:10:21AM +0300, Martin Storsjö wrote: Sticking a full frame in the extradata works, as

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Andreas Rheinhardt
Martin Storsjö: > On Thu, 21 May 2020, Andreas Rheinhardt wrote: > >> Martin Storsjö: >>> On Thu, 21 May 2020, Michael Niedermayer wrote: >>> On Wed, May 20, 2020 at 09:10:21AM +0300, Martin Storsjö wrote: > Sticking a full frame in the extradata works, as the code for writing > the

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Martin Storsjö
On Thu, 21 May 2020, Andreas Rheinhardt wrote: Martin Storsjö: On Thu, 21 May 2020, Michael Niedermayer wrote: On Wed, May 20, 2020 at 09:10:21AM +0300, Martin Storsjö wrote: Sticking a full frame in the extradata works, as the code for writing the avcC/hvcC extracts the relevant parameter

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Andreas Rheinhardt
Martin Storsjö: > On Thu, 21 May 2020, Michael Niedermayer wrote: > >> On Wed, May 20, 2020 at 09:10:21AM +0300, Martin Storsjö wrote: >>> Sticking a full frame in the extradata works, as the code for writing >>> the avcC/hvcC extracts the relevant parameter set NAL units - provided >>> that they

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Martin Storsjö
On Thu, 21 May 2020, Michael Niedermayer wrote: On Wed, May 20, 2020 at 09:10:21AM +0300, Martin Storsjö wrote: Sticking a full frame in the extradata works, as the code for writing the avcC/hvcC extracts the relevant parameter set NAL units - provided that they actually exist in the frame.

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-21 Thread Michael Niedermayer
On Wed, May 20, 2020 at 09:10:21AM +0300, Martin Storsjö wrote: > Sticking a full frame in the extradata works, as the code for writing > the avcC/hvcC extracts the relevant parameter set NAL units - provided > that they actually exist in the frame. > > Some encoders don't provide split out

Re: [FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-20 Thread James Almer
On 5/20/2020 3:10 AM, Martin Storsjö wrote: > Sticking a full frame in the extradata works, as the code for writing > the avcC/hvcC extracts the relevant parameter set NAL units - provided > that they actually exist in the frame. > > Some encoders don't provide split out extradata directly on

[FFmpeg-devel] [PATCH v2] movenc: Use first H264/HEVC frame as extradata, if it is missing

2020-05-20 Thread Martin Storsjö
Sticking a full frame in the extradata works, as the code for writing the avcC/hvcC extracts the relevant parameter set NAL units - provided that they actually exist in the frame. Some encoders don't provide split out extradata directly on init (or at all). In particular, the MediaFoundation