[FFmpeg-devel] [PATCH v2 05/18] avformat/movenc: support for multiple and client-provided track references

2016-08-31 Thread Erkki Seppälä
Instead of one track reference, allow many, and instead of of track reference type (ie. 'cdsc'), allow many. In addition this patch allows client to explicitly add track references with side packet AV_PKT_DATA_TRACK_REFERENCES containing AVTrackReferences (which of there can many many). Internall

Re: [FFmpeg-devel] [PATCH v2 05/18] avformat/movenc: support for multiple and client-provided track references

2016-09-01 Thread Michael Niedermayer
On Wed, Aug 31, 2016 at 02:35:48PM +0300, Erkki Seppälä wrote: > Instead of one track reference, allow many, and instead of > of track reference type (ie. 'cdsc'), allow many. > > In addition this patch allows client to explicitly add track references > with side packet AV_PKT_DATA_TRACK_REFERENCE

Re: [FFmpeg-devel] [PATCH v2 05/18] avformat/movenc: support for multiple and client-provided track references

2016-09-01 Thread Michael Niedermayer
On Wed, Aug 31, 2016 at 02:35:48PM +0300, Erkki Seppälä wrote: > Instead of one track reference, allow many, and instead of > of track reference type (ie. 'cdsc'), allow many. > > In addition this patch allows client to explicitly add track references > with side packet AV_PKT_DATA_TRACK_REFERENCE

Re: [FFmpeg-devel] [PATCH v2 05/18] avformat/movenc: support for multiple and client-provided track references

2016-09-02 Thread Erkki Seppälä
On 09/01/2016 11:30 PM, Michael Niedermayer wrote: missing alloc failure check Fixed. missing checks anything comming out of av_stream_get_side_data() could originate from an attacker and have manually choosen evil values. Oh, well it seems I have trusted it quite a bit more. I will harden