Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-19 Thread Zsolt Vadász via ffmpeg-devel
On Friday, December 15th, 2023 at 11:18 PM, Leo Izen wrote: > On 12/15/23 16:31, Zsolt Vadász via ffmpeg-devel wrote: > > > On Friday, December 15th, 2023 at 10:12 PM, Leo Izen leo.i...@gmail.com > > wrote: > > > > > On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote: > > > > > > > On Fr

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-15 Thread Leo Izen
On 12/15/23 16:31, Zsolt Vadász via ffmpeg-devel wrote: On Friday, December 15th, 2023 at 10:12 PM, Leo Izen wrote: On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote: On Friday, December 15th, 2023 at 12:20 AM, Leo Izen leo.i...@gmail.com wrote: + AVFrame *last; I don't see the pur

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-15 Thread Zsolt Vadász via ffmpeg-devel
On Friday, December 15th, 2023 at 10:12 PM, Leo Izen wrote: > On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote: > > > On Friday, December 15th, 2023 at 12:20 AM, Leo Izen leo.i...@gmail.com > > wrote: > > > > > > + AVFrame *last; > > > > > > I don't see the purpose of keeping this here

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-15 Thread Leo Izen
On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote: On Friday, December 15th, 2023 at 12:20 AM, Leo Izen wrote: + AVFrame *last; I don't see the purpose of keeping this here. The name is misleading, I should have named it `previous`, since it always contains the previous frame. I d

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-15 Thread Zsolt Vadász via ffmpeg-devel
On Friday, December 15th, 2023 at 12:20 AM, Leo Izen wrote: > > + AVFrame *last; > > > I don't see the purpose of keeping this here. > The name is misleading, I should have named it `previous`, since it always contains the previous frame. I did it this way so I could call JxlEncoderCloseInp

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-14 Thread Leo Izen
On 12/13/23 15:53, Zsolt Vadász via ffmpeg-devel wrote: --- configure | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libjxlenc.c | 214 + 3 files changed, 177 insertions(+), 39 deletions(-) diff --git a/configure b/configure index 7d

[FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-13 Thread Zsolt Vadász via ffmpeg-devel
--- configure | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libjxlenc.c | 214 + 3 files changed, 177 insertions(+), 39 deletions(-) diff --git a/configure b/configure index 7d2ee66000..a334a9b1e0 100755 --- a/configure +++ b/configure @@