Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/matroskaenc: Fix memleak upon failure

2019-10-21 Thread James Almer
On 10/15/2019 10:57 PM, Andreas Rheinhardt wrote: > The Matroska muxer up until now leaked memory in two scenarios: > > 1. If an error happened during writing the trailer, as > mkv_write_trailer() returned early without cleaning up. > 2. If mkv_write_header() indicated success despite an error in

[FFmpeg-devel] [PATCH v2 1/2] avformat/matroskaenc: Fix memleak upon failure

2019-10-15 Thread Andreas Rheinhardt
The Matroska muxer up until now leaked memory in two scenarios: 1. If an error happened during writing the trailer, as mkv_write_trailer() returned early without cleaning up. 2. If mkv_write_header() indicated success despite an error in the underlying AVIOContext. In this case avformat_write_head