Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/texturedsp: fix premult2straight inversion

2024-02-02 Thread Connor Worley
Linked are some demo files. I converted a sample to DDS with texconv.exe -f DXT4 -pmalpha sample.png I converted it back to PNG against master with ffmpeg -i sample.dds master.png I converted it back to PNG against this patch with ffmpeg -i sample.dds patch.png The color in master.png is dark due

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/texturedsp: fix premult2straight inversion

2024-02-02 Thread Niklas Haas
On Thu, 01 Feb 2024 17:10:50 -0800 Connor Worley wrote: > +src[0] = (uint8_t) FFMIN(r * 255 / a, 255); > +src[1] = (uint8_t) FFMIN(g * 255 / a, 255); > +src[2] = (uint8_t) FFMIN(b * 255 / a, 255); av_clip_uint8? ___ ffmpeg-devel mailing lis

[FFmpeg-devel] [PATCH v2 1/2] lavc/texturedsp: fix premult2straight inversion

2024-02-01 Thread Connor Worley
This function should convert premultiplied alpha to straight, but does the opposite. Signed-off-by: Connor Worley --- libavcodec/texturedsp.c | 9 ++--- tests/ref/fate/dds-dxt2 | 2 +- tests/ref/fate/dds-dxt4 | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/libavcodec/