Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Rostislav Pehlivanov
Nevermind, I failed to read your suggestion to just use a separate minscaler for noise sf_idx. On 15 April 2015 at 00:05, Rostislav Pehlivanov wrote: > You're right. Unfortunately letting the sf_idx be clipped to the minscale > (+SCALE_MAX_DIFF) causes clipped noise values to be reported by the

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Rostislav Pehlivanov
You're right. Unfortunately letting the sf_idx be clipped to the minscale (+SCALE_MAX_DIFF) causes clipped noise values to be reported by the decoder. Seems like that magic number 4 you suggested might need to be adjusted after all. I also tried testing to see if advancing the minscaler based off o

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Claudio Freire
On Tue, Apr 14, 2015 at 4:52 PM, Rostislav Pehlivanov wrote: > Uhh, can't replicate bug here (freshly built ffmpeg, just applied this patch > only), (md5 for file = 473edd68b91123c3a9c1825271012357). tried other files > and they encode and play fine. Spectrum also looks fine. I also tested other >

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Rostislav Pehlivanov
Uhh, can't replicate bug here (freshly built ffmpeg, just applied this patch only), (md5 for file = 473edd68b91123c3a9c1825271012357). tried other files and they encode and play fine. Spectrum also looks fine. I also tested other random files out of the samples and they all seem file. Know of any o

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Claudio Freire
On Mon, Apr 13, 2015 at 8:33 PM, Rostislav Pehlivanov wrote: > This commit implements the perceptual noise substitution AAC extension. This > is a proof of concept implementation, and as such, is not enabled by default. > This is the second revision of this patch, made after some discussion via

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 12:42:21PM -0300, Claudio Freire wrote: > On Tue, Apr 14, 2015 at 6:10 AM, Michael Niedermayer wrote: > > On Tue, Apr 14, 2015 at 12:33:50AM +0100, Rostislav Pehlivanov wrote: > >> This commit implements the perceptual noise substitution AAC extension. > >> This is a proof

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Claudio Freire
On Tue, Apr 14, 2015 at 6:10 AM, Michael Niedermayer wrote: > On Tue, Apr 14, 2015 at 12:33:50AM +0100, Rostislav Pehlivanov wrote: >> This commit implements the perceptual noise substitution AAC extension. This >> is a proof of concept implementation, and as such, is not enabled by >> default.

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Paul B Mahol
On 4/14/15, Rostislav Pehlivanov wrote: > The images will be retained for 356 days according to the formula left on > the website. As long as it's guaranteed its better than anything else I've > used, and it doesn't touch the images so you can replicate the results. > > Nevertheless, here's a back

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Rostislav Pehlivanov
The images will be retained for 356 days according to the formula left on the website. As long as it's guaranteed its better than anything else I've used, and it doesn't touch the images so you can replicate the results. Nevertheless, here's a backup of them just in case: Original: http://postimg.

Re: [FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 12:33:50AM +0100, Rostislav Pehlivanov wrote: > This commit implements the perceptual noise substitution AAC extension. This > is a proof of concept implementation, and as such, is not enabled by default. > This is the second revision of this patch, made after some discuss

[FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-13 Thread Rostislav Pehlivanov
This commit implements the perceptual noise substitution AAC extension. This is a proof of concept implementation, and as such, is not enabled by default. This is the second revision of this patch, made after some discussion via non-public email due to a mistake. Any changes made since the first