[FFmpeg-devel] [PATCH v2 2/3] avcodec/h274: add film grain synthesis routine

2021-08-17 Thread Niklas Haas
From: Niklas Haas This could arguably also be a vf, but I decided to put it here since decoders are technically required to apply film grain during the output step, and I would rather want to avoid requiring users insert the correct film grain synthesis filter on their own. The code, while in C,

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/h274: add film grain synthesis routine

2021-08-18 Thread James Almer
On 8/17/2021 4:25 PM, Niklas Haas wrote: From: Niklas Haas This could arguably also be a vf, but I decided to put it here since decoders are technically required to apply film grain during the output step, and I would rather want to avoid requiring users insert the correct film grain synthesis

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/h274: add film grain synthesis routine

2021-08-18 Thread Lynne
18 Aug 2021, 17:41 by jamr...@gmail.com: > On 8/17/2021 4:25 PM, Niklas Haas wrote: > >> From: Niklas Haas >> >> This could arguably also be a vf, but I decided to put it here since >> decoders are technically required to apply film grain during the output >> step, and I would rather want to avoi

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/h274: add film grain synthesis routine

2021-08-18 Thread Niklas Haas
On Wed, 18 Aug 2021 12:41:25 -0300 James Almer wrote: > Will this not break compilation with msvc and such? No. Unrecognized or unsupported pragmas are ignored by the implementation (this is specified C behavior). > Also, tree vectorization is know to cause issues in old GCC versions, > and eve