Re: [FFmpeg-devel] [PATCH v2 3/3] [GSoC] [AAC] aacdec: Use macros for constants

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 12:36:48PM -0300, Claudio Freire wrote: > LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH v2 3/3] [GSoC] [AAC] aacdec: Use macros for constants

2015-04-14 Thread Claudio Freire
LGTM On Mon, Apr 13, 2015 at 8:33 PM, Rostislav Pehlivanov wrote: > This commit replaces the previous hardcoded constants with both new and > previously defined macros from aac.h. This change makes it easy for anyone > reading the code to know how encoding and decoding scalefactors works. It's

[FFmpeg-devel] [PATCH v2 3/3] [GSoC] [AAC] aacdec: Use macros for constants

2015-04-13 Thread Rostislav Pehlivanov
This commit replaces the previous hardcoded constants with both new and previously defined macros from aac.h. This change makes it easy for anyone reading the code to know how encoding and decoding scalefactors works. It's also possibly a step in unifying some of the code across both the encoder