Re: [FFmpeg-devel] [PATCH v2 4/5] avformat/chromaprint: Fix writing raw fingerprint

2019-10-15 Thread Gyan
On 16-10-2019 01:21 AM, Gyan wrote: On 16-10-2019 01:11 AM, Andriy Gelman wrote: On Sun, 06. Oct 01:49, Andriy Gelman wrote: From: Andriy Gelman The pointer fp after the call to chromaprint_get_raw_fingerpoint() points to an array of uint32_t whereas the current code assumed just a

Re: [FFmpeg-devel] [PATCH v2 4/5] avformat/chromaprint: Fix writing raw fingerprint

2019-10-15 Thread Gyan
On 16-10-2019 01:11 AM, Andriy Gelman wrote: On Sun, 06. Oct 01:49, Andriy Gelman wrote: From: Andriy Gelman The pointer fp after the call to chromaprint_get_raw_fingerpoint() points to an array of uint32_t whereas the current code assumed just a char stream. Thus when writing the raw

Re: [FFmpeg-devel] [PATCH v2 4/5] avformat/chromaprint: Fix writing raw fingerprint

2019-10-15 Thread Andriy Gelman
On Sun, 06. Oct 01:49, Andriy Gelman wrote: > From: Andriy Gelman > > The pointer fp after the call to chromaprint_get_raw_fingerpoint() points to > an array of uint32_t whereas the current code assumed just a char stream. > Thus when writing the raw fingerprint, the output would be truncated

[FFmpeg-devel] [PATCH v2 4/5] avformat/chromaprint: Fix writing raw fingerprint

2019-10-05 Thread Andriy Gelman
From: Andriy Gelman The pointer fp after the call to chromaprint_get_raw_fingerpoint() points to an array of uint32_t whereas the current code assumed just a char stream. Thus when writing the raw fingerprint, the output would be truncated by a factor of 4. This is fixed in the commit. For