Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable

2023-11-15 Thread Ronald S. Bultje
Hi, On Mon, Nov 13, 2023 at 8:43 AM Ronald S. Bultje wrote: > Hi, > > On Mon, Nov 13, 2023 at 2:55 AM Dai, Jianhui J < > jianhui.j.dai-at-intel@ffmpeg.org> wrote: > >> Oh, this is the preceding patch of: >> `[FFmpeg-devel,v6] avcodec/cbs_vp8: Add support for VP8 codec bitstream` >> >> Probab

Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable

2023-11-13 Thread Ronald S. Bultje
Hi, On Mon, Nov 13, 2023 at 2:55 AM Dai, Jianhui J < jianhui.j.dai-at-intel@ffmpeg.org> wrote: > Oh, this is the preceding patch of: > `[FFmpeg-devel,v6] avcodec/cbs_vp8: Add support for VP8 codec bitstream` > > Probably, I need merge these two together. > It's ok like this, for me. I'll let

Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable

2023-11-12 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Leo > Izen > Sent: Monday, November 13, 2023 2:53 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export > `vp8_token_update_probs` variable > > On 11/12/23

Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable

2023-11-12 Thread Leo Izen
On 11/12/23 20:44, Dai, Jianhui J wrote: This commit exports the `vp8_token_update_probs` variable to internal library scope to facilitate its reuse within the library. Where is this symbol actually needed elsewhere? If it is, perhaps an explanation in the commit message would be ideal. (I ha

Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable

2023-11-12 Thread Dai, Jianhui J
> -Original Message- > From: Dai, Jianhui J > Sent: Monday, November 13, 2023 9:44 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable > > This commit exports the `vp8_token_update_probs` variable to internal library > scope to f

[FFmpeg-devel] [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable

2023-11-12 Thread Dai, Jianhui J
This commit exports the `vp8_token_update_probs` variable to internal library scope to facilitate its reuse within the library. Signed-off-by: Jianhui Dai --- libavcodec/vp8.c | 2 +- libavcodec/vp8data.c | 170 ++ libavcodec/vp8data.h | 171 +---