Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Anton Khirnov
Quoting Roy Funderburk (2023-06-13 19:43:25) > > > On 6/13/23 7:26 AM, Paul B Mahol wrote: > > Why we need new av_* calls, can you elaborate logic behind such approach to > > implement parser? > > > There is common code for dtsuhd audio frame parsing (dtsuhd_common.c) used by > the libavcodec

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Roy Funderburk
On 6/13/23 11:09 AM, Paul B Mahol wrote: > Parser just splits bitstream into packets and packets are then passed to > decoders. Demuxer in such case pass fixed packet sizes to parser minus > optional header/trailer bytes. > There should be no reason for such complexity in parser and/or demuxer if

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Paul B Mahol
On Tue, Jun 13, 2023 at 7:43 PM Roy Funderburk wrote: > > > On 6/13/23 7:26 AM, Paul B Mahol wrote: > > Why we need new av_* calls, can you elaborate logic behind such approach > to > > implement parser? > > > There is common code for dtsuhd audio frame parsing (dtsuhd_common.c) used > by the lib

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Roy Funderburk
On 6/13/23 7:26 AM, Paul B Mahol wrote: > Why we need new av_* calls, can you elaborate logic behind such approach to > implement parser? There is common code for dtsuhd audio frame parsing (dtsuhd_common.c) used by the libavcodec and libavformat DTS-UHD modules. It is complex enough that we

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-06-13 Thread Paul B Mahol
On Mon, May 15, 2023 at 11:15 PM Roy Funderburk wrote: > On 5/15/23 1:35 PM, Michael Niedermayer wrote: > > Seems iam unable to download this. google complains about some 3rd party > cookies > > being disabled when i try to download. This seems new > > > Hi, > > Since google drive is not working

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-05-15 Thread Roy Funderburk
On 5/15/23 1:35 PM, Michael Niedermayer wrote: > Seems iam unable to download this. google complains about some 3rd party > cookies > being disabled when i try to download. This seems new Hi, Since google drive is not working out, I am uploading a small 78k (under the 100k limit) audio file he

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-05-15 Thread Michael Niedermayer
On Mon, May 15, 2023 at 07:50:27AM -0700, Roy Funderburk wrote: > On 5/13/23 12:28 AM, Paul B Mahol wrote: > > How to test this additions, any samples available? > > > Hi, > > I have uploaded a DTS:X audio sample to google drive: > > drive. google. com /drive/folders/ > 1jbfsZvnrBDmgQS0VLKBAns

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-05-15 Thread Roy Funderburk
On 5/13/23 12:28 AM, Paul B Mahol wrote: > How to test this additions, any samples available? Hi, I have uploaded a DTS:X audio sample to google drive: drive. google. com /drive/folders/ 1jbfsZvnrBDmgQS0VLKBAnsZaxgf28vYh?usp=sharing Thanks for looking this over, -Roy ___

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-05-13 Thread Paul B Mahol
On Mon, May 8, 2023 at 7:49 PM Roy Funderburk wrote: > Hi, > > If there is anything I could do to improve this submission, please tell me. > > How to test this additions, any samples available? > Thanks, > -Roy > > On 4/16/23 9:12 PM, Roy Funderburk wrote: > > Parsing of DTS-UHD input files per

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/avcodec: Add DTS-UHD demuxer and parser, movenc support.

2023-05-08 Thread Roy Funderburk
Hi, If there is anything I could do to improve this submission, please tell me. Thanks, -Roy On 4/16/23 9:12 PM, Roy Funderburk wrote: > Parsing of DTS-UHD input files per ETSI TS 102 114 is added > as parser for codec id AV_CODEC_ID_DTSUHD. > > Signed-off-by: Roy Funderburk __