Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: load the sdp file with avio_read_to_bprint()

2021-12-03 Thread lance . lmwang
On Fri, Dec 03, 2021 at 02:50:14PM +0100, Michael Niedermayer wrote: > On Fri, Dec 03, 2021 at 09:14:12PM +0800, lance.lmw...@gmail.com wrote: > > On Thu, Dec 02, 2021 at 11:52:23PM +0100, Michael Niedermayer wrote: > > > On Thu, Dec 02, 2021 at 06:37:38PM +0800, lance.lmw...@gmail.com wrote: > >

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: load the sdp file with avio_read_to_bprint()

2021-12-03 Thread Michael Niedermayer
On Fri, Dec 03, 2021 at 09:14:12PM +0800, lance.lmw...@gmail.com wrote: > On Thu, Dec 02, 2021 at 11:52:23PM +0100, Michael Niedermayer wrote: > > On Thu, Dec 02, 2021 at 06:37:38PM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > > > this allows getting rid of the hardcoded

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: load the sdp file with avio_read_to_bprint()

2021-12-03 Thread lance . lmwang
On Thu, Dec 02, 2021 at 11:52:23PM +0100, Michael Niedermayer wrote: > On Thu, Dec 02, 2021 at 06:37:38PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > this allows getting rid of the hardcoded max size of SDP. > > > > Reviewed-by: Martin Storsjö > > Signed-off-by: Limin

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: load the sdp file with avio_read_to_bprint()

2021-12-02 Thread lance . lmwang
On Thu, Dec 02, 2021 at 11:52:23PM +0100, Michael Niedermayer wrote: > On Thu, Dec 02, 2021 at 06:37:38PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > this allows getting rid of the hardcoded max size of SDP. > > > > Reviewed-by: Martin Storsjö > > Signed-off-by: Limin

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: load the sdp file with avio_read_to_bprint()

2021-12-02 Thread Michael Niedermayer
On Thu, Dec 02, 2021 at 06:37:38PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > this allows getting rid of the hardcoded max size of SDP. > > Reviewed-by: Martin Storsjö > Signed-off-by: Limin Wang > --- > libavformat/rtsp.c | 25 + > 1 file changed, 9

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: load the sdp file with avio_read_to_bprint()

2021-12-02 Thread Martin Storsjö
On Thu, 2 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang this allows getting rid of the hardcoded max size of SDP. Reviewed-by: Martin Storsjö Signed-off-by: Limin Wang --- libavformat/rtsp.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) LGTM

[FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: load the sdp file with avio_read_to_bprint()

2021-12-02 Thread lance . lmwang
From: Limin Wang this allows getting rid of the hardcoded max size of SDP. Reviewed-by: Martin Storsjö Signed-off-by: Limin Wang --- libavformat/rtsp.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index