Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-29 Thread Nicolas George
Marton Balint (12020-07-29): > Thanks for working on this. I agree that proper (as RFC compliant as it can > be) URL parsing is needed here. Probably we should clearly document > differences from RFC compliant parsing, if we cannot do it entirely RFC > compliantly... Indeed. Unfortunately, that ma

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-29 Thread Marton Balint
On Wed, 29 Jul 2020, Nicolas George wrote: Zlomek, Josef (12020-07-29): I also noticed that there are many more bugs in ff_make_absolute_url() I just fixed one of them. I am looking forward for your complete fix. I think the key to a working version is to properly parse URLs first. Then we

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-29 Thread Nicolas George
Zlomek, Josef (12020-07-29): > I also noticed that there are many more bugs in ff_make_absolute_url() > I just fixed one of them. > I am looking forward for your complete fix. I think the key to a working version is to properly parse URLs first. Then we can parse the base and relative part, and bu

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-29 Thread Zlomek, Josef
On Wed, Jul 29, 2020 at 12:01 PM Nicolas George wrote: > I am afraid ff_make_absolute_url() as it is is broken beyond repair. For > example: > > http://server/menu redirect?url=http://otherserver/target => > redirect?url=http://otherserver/target > > while the result should have been > > http:/

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-29 Thread Nicolas George
Josef Zlomek (12020-07-28): > Fixes: 8814 > > The logic for removing ".." path components and their corresponding > upper directories was reworked. > > Now, the function trim_double_dot_url splits the path by "/" into > components, and processes the components one ny one: > - if the component is

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-28 Thread Zlomek, Josef
I have removed tmp_path from function trim_double_dot_url I did not change the function ff_make_absolute_url much, as I wanted to just fix handling of "..". Josef On Tue, Jul 28, 2020 at 12:59 PM Steven Liu wrote: > Zlomek, Josef 于2020年7月28日周二 下午6:58写道: > > > > see version 3 > Isn't this vers

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-28 Thread Steven Liu
Zlomek, Josef 于2020年7月28日周二 下午6:58写道: > > see version 3 Isn't this version? or maybe your mean is version 4? > > On Tue, Jul 28, 2020 at 12:37 PM Steven Liu wrote: > > > Josef Zlomek 于2020年7月28日周二 下午12:11写道: > > > > > > Fixes: 8814 > > > > > > The logic for removing ".." path components and thei

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-28 Thread Zlomek, Josef
see version 3 On Tue, Jul 28, 2020 at 12:37 PM Steven Liu wrote: > Josef Zlomek 于2020年7月28日周二 下午12:11写道: > > > > Fixes: 8814 > > > > The logic for removing ".." path components and their corresponding > > upper directories was reworked. > > > > Now, the function trim_double_dot_url splits the p

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-28 Thread Steven Liu
Josef Zlomek 于2020年7月28日周二 下午12:11写道: > > Fixes: 8814 > > The logic for removing ".." path components and their corresponding > upper directories was reworked. > > Now, the function trim_double_dot_url splits the path by "/" into > components, and processes the components one ny one: > - if the co

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-28 Thread Zlomek, Josef
You are right, it is a typo. On Tue, Jul 28, 2020 at 12:02 PM Zane van Iperen wrote: > On Tue, 28 Jul 2020 06:10:57 +0200 > "Josef Zlomek" wrote: > > > > > Now, the function trim_double_dot_url splits the path by "/" into > > components, and processes the components one ny one: > > Typo: ny sho

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-28 Thread Zane van Iperen
On Tue, 28 Jul 2020 06:10:57 +0200 "Josef Zlomek" wrote: > > Now, the function trim_double_dot_url splits the path by "/" into > components, and processes the components one ny one: Typo: ny should be by, I'm assuming? ___ ffmpeg-devel mailing list f

[FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-27 Thread Josef Zlomek
Fixes: 8814 The logic for removing ".." path components and their corresponding upper directories was reworked. Now, the function trim_double_dot_url splits the path by "/" into components, and processes the components one ny one: - if the component is "..", the last path component in output buff