Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-08-02 Thread Xiang, Haihao
On Mon, 2022-08-01 at 11:12 +0200, Anton Khirnov wrote: > Hi, > the concept is generally ok, but I have a few comments on the > implementation. > > Quoting Xiang, Haihao (2022-07-25 06:30:51) > > +static const AVCodec *choose_decoder2(InputStream *ist, OptionsContext *o, > > AVFormatContext *s,

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-08-01 Thread Anton Khirnov
Hi, the concept is generally ok, but I have a few comments on the implementation. Quoting Xiang, Haihao (2022-07-25 06:30:51) > +static const AVCodec *choose_decoder2(InputStream *ist, OptionsContext *o, > AVFormatContext *s, AVStream *st) > +{ > +char *codec_name = NULL; > + > +

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-07-31 Thread Xiang, Haihao
> > Sent: Friday, July 29, 2022 10:50 AM > > > > To: FFmpeg development discussions and patches > > > de...@ffmpeg.org> > > > > Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider > > > > HW > > > > acceleration metho

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-07-31 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Monday, August 1, 2022 3:53 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW > acceleration method when selecting decoder > >

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-07-31 Thread Xiang, Haihao
t; Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW > > acceleration method when selecting decoder > > > > Hi, > > > > On Fri, Jul 29, 2022 at 4:38 PM Xiang, Haihao < > > haihao.xiang-at-intel@ffmpeg.org> wrote: > > > >

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-07-29 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Ronald S. Bultje > Sent: Friday, July 29, 2022 10:50 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW > accelerati

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-07-29 Thread Ronald S. Bultje
Hi, On Fri, Jul 29, 2022 at 4:38 PM Xiang, Haihao < haihao.xiang-at-intel@ffmpeg.org> wrote: > libdav1d is the preferred AV1 decoder in FFmpeg, libdav1d is always used > when > running the command below even if user expects vaapi or other HW > acceleration > methods. > I think that is a

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-07-29 Thread Xiang, Haihao
On Mon, 2022-07-25 at 12:30 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Usually a HW decoder is expected when user specifies a HW acceleration > method via -hwaccel option, however the current implementation doesn't > take HW acceleration method into account, it is possible to select a

[FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-07-24 Thread Xiang, Haihao
From: Haihao Xiang Usually a HW decoder is expected when user specifies a HW acceleration method via -hwaccel option, however the current implementation doesn't take HW acceleration method into account, it is possible to select a SW decoder. For example: $ ffmpeg -hwaccel vaapi -i av1.mp4 -f