Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/golomb: Prevent shift by negative number

2020-07-28 Thread Michael Niedermayer
On Mon, Jul 27, 2020 at 11:08:07AM +0200, Andreas Rheinhardt wrote: > This happened in get_ue_golomb() if the cached bitstream reader was in > use, because there was no check to handle the case of the read value > not being in the supported range. > For consistency with the uncached bitstream

[FFmpeg-devel] [PATCH v3 2/5] avcodec/golomb: Prevent shift by negative number

2020-07-27 Thread Andreas Rheinhardt
This happened in get_ue_golomb() if the cached bitstream reader was in use, because there was no check to handle the case of the read value not being in the supported range. For consistency with the uncached bitstream reader and for compliance with the documentation, every value not in the 0-8190