Re: [FFmpeg-devel] [PATCH v4] Add 2 timestamp print formats

2019-07-03 Thread Ulf Zibis
Am 03.07.19 um 16:52 schrieb Nicolas George: > The features you add here seem useful, but I wonder: have you considered > the option of making them a single function with a parameter to select > the format? That may make it easier to add new formats later, and have > them supported by any componen

Re: [FFmpeg-devel] [PATCH v4] Add 2 timestamp print formats

2019-07-03 Thread Ulf Zibis
Am 03.07.19 um 16:49 schrieb Ulf Zibis: > Am 03.07.19 um 10:52 schrieb Michael Niedermayer: > -#define av_ts2timestr(ts, tb) > av_ts_make_time_string((char[AV_TS_MAX_STRING_SIZE]){0}, ts, tb) > +#define av_ts2timestr(ts, tb) > av_ts_make_time_string((char[AV_TS_MAX_STRING_SIZE]){

Re: [FFmpeg-devel] [PATCH v4] Add 2 timestamp print formats

2019-07-03 Thread Nicolas George
Ulf Zibis (12019-07-03): > From 5d62406366560cfab5711120c514a77867bd8c2e Mon Sep 17 00:00:00 2001 > From: Ulf Zibis > Date: 29.06.2019, 17:52:06 > > avutil/timestamp: added av_ts2us() and 2 new print formats The features you add here seem useful, but I wonder: have you considered the option of m

Re: [FFmpeg-devel] [PATCH v4] Add 2 timestamp print formats

2019-07-03 Thread Ulf Zibis
Am 03.07.19 um 10:52 schrieb Michael Niedermayer: > -#define av_ts2timestr(ts, tb) av_ts_make_time_string((char[AV_TS_MAX_STRING_SIZE]){0}, ts, tb) +#define av_ts2timestr(ts, tb) av_ts_make_time_string((char[AV_TS_MAX_STRING_SIZE]){'\0'}, ts, tb) + +/** + * Fil