[FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-19 Thread Ludmila Glinskih
Signed-off-by: Ludmila Glinskih --- libavcodec/Makefile| 1 + libavcodec/api-flac-test.c | 290 + tests/fate/libavcodec.mak | 6 + 3 files changed, 297 insertions(+) create mode 100644 libavcodec/api-flac-test.c diff --git a/libavcodec/Ma

Re: [FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-20 Thread Michael Niedermayer
On Mon, Apr 20, 2015 at 03:03:08AM +0300, Ludmila Glinskih wrote: > Signed-off-by: Ludmila Glinskih > --- > libavcodec/Makefile| 1 + > libavcodec/api-flac-test.c | 290 > + > tests/fate/libavcodec.mak | 6 + > 3 files changed, 297 inserti

Re: [FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-20 Thread Michael Niedermayer
On Mon, Apr 20, 2015 at 02:38:47PM +0200, Michael Niedermayer wrote: > On Mon, Apr 20, 2015 at 03:03:08AM +0300, Ludmila Glinskih wrote: > > Signed-off-by: Ludmila Glinskih > > --- > > libavcodec/Makefile| 1 + > > libavcodec/api-flac-test.c | 290 > > ++

Re: [FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-20 Thread Kieran Kunhya
On 20 April 2015 at 01:03, Ludmila Glinskih wrote: > Signed-off-by: Ludmila Glinskih > --- > libavcodec/Makefile| 1 + > libavcodec/api-flac-test.c | 290 > + I would put this in its own directory. I think the next thing you should work on i

Re: [FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-20 Thread James Almer
On 19/04/15 9:03 PM, Ludmila Glinskih wrote: > +static int run_test(AVCodec *enc, AVCodec *dec, AVCodecContext *enc_ctx, > +AVCodecContext *dec_ctx) > +{ > +AVPacket enc_pkt; > +AVFrame *in_frame, *out_frame; > +uint8_t *raw_in = NULL, *raw_out = NULL; > +int in

Re: [FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-21 Thread Michael Niedermayer
Hi Ludmila It appears several developers had additional review comments on your patch ccing you so you dont miss the mail On Mon, Apr 20, 2015 at 03:03:08AM +0300, Ludmila Glinskih wrote: > Signed-off-by: Ludmila Glinskih [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78

Re: [FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-21 Thread Ludmila Glinskih
Sorry for the delay, thanks for comments! вт, 21 апр. 2015 г. в 1:40, Kieran Kunhya : > On 20 April 2015 at 01:03, Ludmila Glinskih wrote: > > Signed-off-by: Ludmila Glinskih > > --- > > libavcodec/Makefile| 1 + > > libavcodec/api-flac-test.c | 290 >

Re: [FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-21 Thread Ludmila Glinskih
OOPS вт, 21 апр. 2015 г. в 8:03, James Almer : > On 19/04/15 9:03 PM, Ludmila Glinskih wrote: > > > +static int run_test(AVCodec *enc, AVCodec *dec, AVCodecContext *enc_ctx, > > +AVCodecContext *dec_ctx) > > +{ > > +AVPacket enc_pkt; > > +AVFrame *in_frame, *ou

Re: [FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

2015-04-21 Thread Kieran Kunhya
On 21 April 2015 at 21:52, Ludmila Glinskih wrote: > Sorry for the delay, thanks for comments! > > вт, 21 апр. 2015 г. в 1:40, Kieran Kunhya : > >> On 20 April 2015 at 01:03, Ludmila Glinskih wrote: >> > Signed-off-by: Ludmila Glinskih >> > --- >> > libavcodec/Makefile| 1 + >> > liba