Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-06-08 Thread James Zern
On Mon, Jun 8, 2020 at 2:56 AM Moritz Barsnick wrote: > > On Sun, May 10, 2020 at 00:59:25 +0900, Ryo Hirafuji wrote: > > I can create and send a new patch without these workaround lines, but of > > course, it will crash if the ffmpeg will be built with older versions of > > libaom. > > Actually,

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-06-08 Thread Moritz Barsnick
On Sun, May 10, 2020 at 00:59:25 +0900, Ryo Hirafuji wrote: > I can create and send a new patch without these workaround lines, but of > course, it will crash if the ffmpeg will be built with older versions of > libaom. Actually, it depends on the runtime version of the library, not which version

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-05-09 Thread Ryo Hirafuji
Sorry, Resolved bug is this: https://bugs.chromium.org/p/aomedia/issues/detail?id=2639 and we no longer need these lines: +rawimg->planes[AOM_PLANE_U] = frame->data[0]; +rawimg->planes[AOM_PLANE_V] = frame->data[0]; +rawimg->stride[AOM_PLANE_U] = frame->linesi

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-05-09 Thread Ryo Hirafuji
Hi. https://crbug.com/aomedia/2545 This bug is resolved and we no longer need these lines to avoid crash in libaom. > -rawimg->planes[AOM_PLANE_U] = frame->data[1]; > -rawimg->planes[AOM_PLANE_V] = frame->data[2]; > -rawimg->stride[AOM_PLANE_U] = frame->linesize[1]; > -

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-15 Thread James Zern
On Wed, Apr 15, 2020 at 8:14 AM James Almer wrote: > > On 4/14/2020 9:26 PM, James Zern wrote: > > On Tue, Apr 14, 2020 at 3:57 AM Ryo Hirafuji > > wrote: > >> > >> Thanks for the review! > >> > >> This should bump the micro version number in libavcodec/version.h. > >> > >> > >> OK, I will bump

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-15 Thread James Almer
On 4/14/2020 9:26 PM, James Zern wrote: > On Tue, Apr 14, 2020 at 3:57 AM Ryo Hirafuji > wrote: >> >> Thanks for the review! >> >> This should bump the micro version number in libavcodec/version.h. >> >> >> OK, I will bump up the version when the problem below is solved. >> > > If we want to go

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-14 Thread James Zern
On Tue, Apr 14, 2020 at 3:57 AM Ryo Hirafuji wrote: > > Thanks for the review! > > This should bump the micro version number in libavcodec/version.h. > > > OK, I will bump up the version when the problem below is solved. > If we want to go for compatibility with different versions of the library

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-14 Thread Ryo Hirafuji
Thanks for the review! This should bump the micro version number in libavcodec/version.h. OK, I will bump up the version when the problem below is solved. > That's annoying. I filed a bug to track [1]. The monochrome flag > itself seems unnecessary for the library rather than just an image > f

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-13 Thread James Zern
Hi, On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji wrote: > > From: Ryo Hirafuji > > AV1 decoders, libaomdec and libdav1d, both support grayscale image. > However, libaomenc does not support it yet. > In this patch, I add a grayscale image support also to libaomenc. > > Fixes ticket #7599 > --- >

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-11 Thread Ryo Hirafuji
Hi! I would like to discuss this patch, but I can't find who is the maintainer of this codec. https://github.com/FFmpeg/FFmpeg/blob/master/MAINTAINERS Does anyone know? If something was BAD, I would like to rewrite it better. If splitting this patch into gray support and lossless support patch is

[FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-07 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 decoders, libaomdec and libdav1d, both support grayscale image. However, libaomenc does not support it yet. In this patch, I add a grayscale image support also to libaomenc. Fixes ticket #7599 --- libavcodec/libaomenc.c | 40 +--- 1 fil