Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-28 Thread Martin Storsjö
On Tue, 28 Apr 2020, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of Martin Storsjö Sent: Tuesday, April 28, 2020 14:31 To: Fu, Linjie Cc: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support On Tue, 28

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-28 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Martin Storsjö > Sent: Tuesday, April 28, 2020 14:31 > To: Fu, Linjie > Cc: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add > default qmin/qmax support

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-28 Thread Martin Storsjö
On Tue, 28 Apr 2020, Fu, Linjie wrote: From: Martin Storsjö Sent: Tuesday, April 28, 2020 14:19 To: Fu, Linjie Cc: FFmpeg development discussions and patches Subject: RE: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support On Tue, 28 Apr 2020, Fu, Linjie wrote

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-28 Thread Fu, Linjie
> From: Martin Storsjö > Sent: Tuesday, April 28, 2020 14:19 > To: Fu, Linjie > Cc: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: RE: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add > default qmin/qmax support > > On Tue, 28

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-28 Thread Martin Storsjö
On Tue, 28 Apr 2020, Fu, Linjie wrote: From: Martin Storsjö Sent: Tuesday, April 28, 2020 03:27 If qmax/qmin < 0, i.e. wasn't specified by the user, wouldn't it be better to not touch param.iMax/MinQp at all (and use the default value of the library, which may change between versions),

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-27 Thread Fu, Linjie
> From: Martin Storsjö > Sent: Tuesday, April 28, 2020 03:27 > > If qmax/qmin < 0, i.e. wasn't specified by the user, wouldn't it be better > to not touch param.iMax/MinQp at all (and use the default value of the > library, which may change between versions), instead of overriding it with > a

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: Set default QP range to (1, 51) instead of (2, 32). QP = 0 is not well supported currently in libopenh264. If iMaxQp/iMinQp equals 0, the QP range would be changed unexpectedly inside libopenh264 with a warning: Warning:Change QP Range from(0,51) to

[FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-14 Thread Linjie Fu
Set default QP range to (1, 51) instead of (2, 32). QP = 0 is not well supported currently in libopenh264. If iMaxQp/iMinQp equals 0, the QP range would be changed unexpectedly inside libopenh264 with a warning: Warning:Change QP Range from(0,51) to (12,42) [1]