Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread myp...@gmail.com
On Wed, Apr 22, 2020 at 7:55 PM Anton Khirnov wrote: > > Quoting myp...@gmail.com (2020-04-22 10:56:52) > > On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov wrote: > > > Making it inline would invalidate the whole point, which is to avoid > > > embedding the size of the struct into the calling

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread Anton Khirnov
Quoting myp...@gmail.com (2020-04-22 10:56:52) > On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov wrote: > > Making it inline would invalidate the whole point, which is to avoid > > embedding the size of the struct into the calling program. > > > Do you mean I need to split the av_dovi_alloc

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread myp...@gmail.com
On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov wrote: > > Quoting myp...@gmail.com (2020-04-22 05:39:38) > > On Tue, Apr 21, 2020 at 2:23 PM Anton Khirnov wrote: > > > > > > Quoting myp...@gmail.com (2020-04-21 04:47:42) > > > > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > > > > > >

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread myp...@gmail.com
On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov wrote: > > Quoting myp...@gmail.com (2020-04-22 05:39:38) > > On Tue, Apr 21, 2020 at 2:23 PM Anton Khirnov wrote: > > > > > > Quoting myp...@gmail.com (2020-04-21 04:47:42) > > > > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > > > > > >

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread Anton Khirnov
Quoting myp...@gmail.com (2020-04-22 05:39:38) > On Tue, Apr 21, 2020 at 2:23 PM Anton Khirnov wrote: > > > > Quoting myp...@gmail.com (2020-04-21 04:47:42) > > > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > > > > > > > Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07) > > > > > I'd

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-21 Thread myp...@gmail.com
On Tue, Apr 21, 2020 at 2:23 PM Anton Khirnov wrote: > > Quoting myp...@gmail.com (2020-04-21 04:47:42) > > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > > > > > Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07) > > > > I'd like to ask opinions whether a installed header for just one

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-21 Thread Anton Khirnov
Quoting myp...@gmail.com (2020-04-21 04:47:42) > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > > > Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07) > > > I'd like to ask opinions whether a installed header for just one > > > structure is a good idea. > > > > I see no problem with it.

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-20 Thread myp...@gmail.com
On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07) > > I'd like to ask opinions whether a installed header for just one structure > > is a good idea. > > I see no problem with it. More smaller headers is better that a few big > headers. > >

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-20 Thread Anton Khirnov
Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07) > I'd like to ask opinions whether a installed header for just one structure is > a good idea. I see no problem with it. More smaller headers is better that a few big headers. Another issue is that this struct has no constructor and thus cannot

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-19 Thread myp...@gmail.com
On Sun, Apr 19, 2020 at 4:25 PM Jean-Baptiste Kempf wrote: > > I'd like to ask opinions whether a installed header for just one structure is > a good idea. > It's follow the style like AVReplayGain, so add a new file in libavutil > On Sun, Apr 19, 2020, at 03:07, Jun Zhao wrote: > > From:

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-19 Thread Jean-Baptiste Kempf
I'd like to ask opinions whether a installed header for just one structure is a good idea. On Sun, Apr 19, 2020, at 03:07, Jun Zhao wrote: > From: vacingfang > > add DOVI related struct > > Signed-off-by: vacingfang > --- > libavutil/Makefile| 1 + > libavutil/dovi_meta.h | 58 >

[FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-18 Thread Jun Zhao
From: vacingfang add DOVI related struct Signed-off-by: vacingfang --- libavutil/Makefile| 1 + libavutil/dovi_meta.h | 58 +++ 2 files changed, 59 insertions(+) create mode 100644 libavutil/dovi_meta.h diff --git a/libavutil/Makefile