Re: [FFmpeg-devel] [PATCH v4 2/9] avformat/utils: unref packet on AVInputFormat.read_packet() failure

2019-09-28 Thread Andreas Rheinhardt
James Almer: > On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: >> From: James Almer >> >> Demuxers may have allocated a packet before encountering an error and >> aborting. > > Fun thing about this, the doxy states that packets should be freed on > error before returning from the demuxer, so tec

Re: [FFmpeg-devel] [PATCH v4 2/9] avformat/utils: unref packet on AVInputFormat.read_packet() failure

2019-09-28 Thread James Almer
On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: > From: James Almer > > Demuxers may have allocated a packet before encountering an error and > aborting. Fun thing about this, the doxy states that packets should be freed on error before returning from the demuxer, so technically the apng demuxe

Re: [FFmpeg-devel] [PATCH v4 2/9] avformat/utils: unref packet on AVInputFormat.read_packet() failure

2019-09-25 Thread James Almer
On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: > From: James Almer > > Demuxers may have allocated a packet before encountering an error and > aborting. > > Fixes ticket #8150 > > Signed-off-by: James Almer > --- > Earlier versions of this patchset used av_init_packet() together with > setti

[FFmpeg-devel] [PATCH v4 2/9] avformat/utils: unref packet on AVInputFormat.read_packet() failure

2019-09-20 Thread Andreas Rheinhardt
From: James Almer Demuxers may have allocated a packet before encountering an error and aborting. Fixes ticket #8150 Signed-off-by: James Almer --- Earlier versions of this patchset used av_init_packet() together with setting the size and data to zero/NULL. This would have caused memleaks when