> From: Martin Storsjö
> Sent: Tuesday, April 28, 2020 16:08
> To: Fu, Linjie
> Cc: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: RE: [FFmpeg-devel] [PATCH v4 2/9] lavc/libopenh264enc: add
> default gop size and bit rate
>
> On Tue, 28
On Tue, 28 Apr 2020, Fu, Linjie wrote:
From: Martin Storsjö
Sent: Tuesday, April 28, 2020 14:28
To: Fu, Linjie
Cc: FFmpeg development discussions and patches
Subject: RE: [FFmpeg-devel] [PATCH v4 2/9] lavc/libopenh264enc: add
default gop size and bit rate
On Tue, 28 Apr 2020, Fu, Linjie
> From: Martin Storsjö
> Sent: Tuesday, April 28, 2020 14:28
> To: Fu, Linjie
> Cc: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: RE: [FFmpeg-devel] [PATCH v4 2/9] lavc/libopenh264enc: add
> default gop size and bit rate
>
> On Tue, 28
On Tue, 28 Apr 2020, Fu, Linjie wrote:
From: Martin Storsjö
Sent: Tuesday, April 28, 2020 03:28
static const AVCodecDefault svc_enc_defaults[] = {
+{ "b", "0" },
+{ "g", "120" },
{ "qmin", "-1"},
Why do you hardcode a value for g here, but put the
> From: Martin Storsjö
> Sent: Tuesday, April 28, 2020 03:28
> > static const AVCodecDefault svc_enc_defaults[] = {
> > +{ "b", "0" },
> > +{ "g", "120" },
> > { "qmin", "-1"},
>
> Why do you hardcode a value for g here, but put the default bitrate
On Wed, 15 Apr 2020, Linjie Fu wrote:
It would be 200kbps bitrate with gop size = 12 by default
which generated too many IDR frames in rather low bit rate.
The quality would be poor.
Set these default values according to vaapi encoder, and
use 2Mbps bitrate if user doesn't set it explicitly as
It would be 200kbps bitrate with gop size = 12 by default
which generated too many IDR frames in rather low bit rate.
The quality would be poor.
Set these default values according to vaapi encoder, and
use 2Mbps bitrate if user doesn't set it explicitly as
nvenc sugguested.
Signed-off-by: Linjie
