Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-08 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Ronald S. > Bultje > Sent: Thursday, November 9, 2023 12:38 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 > codec bitstream

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-08 Thread Ronald S. Bultje
Hi, On Wed, Nov 8, 2023 at 10:55 AM Ronald S. Bultje wrote: > Hi Jianhui, > > On Tue, Nov 7, 2023 at 8:52 PM Dai, Jianhui J < > jianhui.j.dai-at-intel@ffmpeg.org> wrote: > >> The smaller delta patch to export the variable: >> https://patchwork.ffmpeg.org/project/ffmpeg/patch/dm6pr11mb2681863

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-08 Thread Ronald S. Bultje
Hi Jianhui, On Tue, Nov 7, 2023 at 8:52 PM Dai, Jianhui J < jianhui.j.dai-at-intel@ffmpeg.org> wrote: > The smaller delta patch to export the variable: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/dm6pr11mb268186349e600824e1577dfdb1...@dm6pr11mb2681.namprd11.prod.outlook.com/ > Persona

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-07 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Ronald S. > Bultje > Sent: Wednesday, November 8, 2023 4:26 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 > codec bitstream

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-07 Thread Ronald S. Bultje
development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for > > VP8 codec bitstream > > > > Hi, > > > > On Mon, Nov 6, 2023 at 7:07 AM Ronald S. Bultje > > wrote: > > > >

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-06 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of > Ronald S. Bultje > Sent: Monday, November 6, 2023 8:08 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for > VP8

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-06 Thread Ronald S. Bultje
Hi, On Mon, Nov 6, 2023 at 7:07 AM Ronald S. Bultje wrote: > On Sun, Nov 5, 2023 at 11:13 PM Dai, Jianhui J < > jianhui.j.dai-at-intel@ffmpeg.org> wrote: > >> > > +static const uint8_t vp8_token_update_probs[4][8][3][11] = { >> > >> > It would be nice if these symbols could be re-used from t

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-06 Thread Ronald S. Bultje
Hi, On Sun, Nov 5, 2023 at 11:13 PM Dai, Jianhui J < jianhui.j.dai-at-intel@ffmpeg.org> wrote: > > > +static const uint8_t vp8_token_update_probs[4][8][3][11] = { > > > > It would be nice if these symbols could be re-used from the existing vp8 > > native decoder, instead of duplicating them?

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-05 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of > Ronald S. Bultje > Sent: Monday, November 6, 2023 10:48 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for > VP8

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-05 Thread Ronald S. Bultje
Hi, On Sun, Nov 5, 2023 at 7:56 PM Dai, Jianhui J < jianhui.j.dai-at-intel@ffmpeg.org> wrote: > This commit adds support for VP8 bitstream read methods to the cbs > codec. This enables the trace_headers bitstream filter to support VP8, > in addition to AV1, H.264, H.265, and VP9. This can be

[FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-05 Thread Dai, Jianhui J
This commit adds support for VP8 bitstream read methods to the cbs codec. This enables the trace_headers bitstream filter to support VP8, in addition to AV1, H.264, H.265, and VP9. This can be useful for debugging VP8 stream issues. The CBS VP8 implements a simple VP8 boolean decoder using GetBitC