Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check

2024-01-24 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Wednesday, January 24, 2024 7:41 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in > fixed() and improve the pos check >

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check

2024-01-24 Thread Anton Khirnov
Quoting Dai, Jianhui J (2024-01-23 03:58:24) > This commit adds value range checks to cbs_vp8_read_unsigned_le, > migrates fixed() to use it, and enforces little-endian consistency for > all read methods. > > The VP8 compressed header may not be byte-aligned due to boolean coding. > Use bitwise co

Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check

2024-01-23 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Tuesday, January 23, 2024 10:58 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in > fixed() and improve the pos check >

[FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check

2024-01-22 Thread Dai, Jianhui J
This commit adds value range checks to cbs_vp8_read_unsigned_le, migrates fixed() to use it, and enforces little-endian consistency for all read methods. The VP8 compressed header may not be byte-aligned due to boolean coding. Use bitwise comparison to prevent the potential overread. TETS: ffmpeg