Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 07:44 PM, Lou Logan wrote: On Wed, Dec 23, 2015, at 03:05 AM, Mats Peterson wrote: OK Clement, I have changed some of the stuff you complained about. Those were not complaints, but a comments from a review. Here's a real complaint: I find it increasingly hard to follow your stre

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Lou Logan
On Wed, Dec 23, 2015, at 03:05 AM, Mats Peterson wrote: > OK Clement, I have changed some of the stuff you complained about. Those were not complaints, but a comments from a review. Here's a real complaint: I find it increasingly hard to follow your stream-of-consciousness style of replies. You

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 05:26 PM, Mats Peterson wrote: On 12/23/2015 05:24 PM, Mats Peterson wrote: On 12/23/2015 05:17 PM, Alexander Strasser wrote: On 2015-12-23 13:33 +0100, Hendrik Leppkes wrote: Am 23.12.2015 13:28 schrieb "Mats Peterson" < matsp888-at-yahoo@ffmpeg.org>: On 12/23/2015 01:15 P

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 05:24 PM, Mats Peterson wrote: On 12/23/2015 05:17 PM, Alexander Strasser wrote: On 2015-12-23 13:33 +0100, Hendrik Leppkes wrote: Am 23.12.2015 13:28 schrieb "Mats Peterson" < matsp888-at-yahoo@ffmpeg.org>: On 12/23/2015 01:15 PM, Mats Peterson wrote: On 12/23/2015 01:13

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 05:17 PM, Alexander Strasser wrote: On 2015-12-23 13:33 +0100, Hendrik Leppkes wrote: Am 23.12.2015 13:28 schrieb "Mats Peterson" < matsp888-at-yahoo@ffmpeg.org>: On 12/23/2015 01:15 PM, Mats Peterson wrote: On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote: Mats Peterson f

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Alexander Strasser
On 2015-12-23 13:33 +0100, Hendrik Leppkes wrote: > Am 23.12.2015 13:28 schrieb "Mats Peterson" < > matsp888-at-yahoo@ffmpeg.org>: > > > > On 12/23/2015 01:15 PM, Mats Peterson wrote: > >> > >> On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote: > >>> > >>> Mats Peterson ffmpeg.org> writes: > >>>

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 01:37 PM, Mats Peterson wrote: On 12/23/2015 01:33 PM, Hendrik Leppkes wrote: Am 23.12.2015 13:28 schrieb "Mats Peterson" < matsp888-at-yahoo@ffmpeg.org>: On 12/23/2015 01:15 PM, Mats Peterson wrote: On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.or

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 01:33 PM, Hendrik Leppkes wrote: Am 23.12.2015 13:28 schrieb "Mats Peterson" < matsp888-at-yahoo@ffmpeg.org>: On 12/23/2015 01:15 PM, Mats Peterson wrote: On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: In matroskadec.c, I'm also puttin

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Hendrik Leppkes
Am 23.12.2015 13:28 schrieb "Mats Peterson" < matsp888-at-yahoo@ffmpeg.org>: > > On 12/23/2015 01:15 PM, Mats Peterson wrote: >> >> On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote: >>> >>> Mats Peterson ffmpeg.org> writes: >>> >> In matroskadec.c, I'm also putting the palette in 'extradata'

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 01:15 PM, Mats Peterson wrote: On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: In matroskadec.c, I'm also putting the palette in 'extradata', like it's done for V_MS/VFW/FOURCC; this is a requirement in order for MPlayer to recognize the palette

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: In matroskadec.c, I'm also putting the palette in 'extradata', like it's done for V_MS/VFW/FOURCC; this is a requirement in order for MPlayer to recognize the palette. This is wrong, please remove this hunk.

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > >> In matroskadec.c, I'm also putting the palette in 'extradata', > >> like it's done for V_MS/VFW/FOURCC; this is a requirement in > >> order for MPlayer to recognize the palette. > > > > This is wrong, please remove this hunk. > The reason for this is becaus

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 01:07 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: In matroskadec.c, I'm also putting the palette in 'extradata', like it's done for V_MS/VFW/FOURCC; this is a requirement in order for MPlayer to recognize the palette. This is wrong, please remove this hunk. T

Re: [FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > In matroskadec.c, I'm also putting the palette in 'extradata', > like it's done for V_MS/VFW/FOURCC; this is a requirement in > order for MPlayer to recognize the palette. This is wrong, please remove this hunk. The reason it is needed for AVI is not MPlaye

[FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
OK Clement, I have changed some of the stuff you complained about. Regarding my being the sole author, well, the *idea* has been there before in the shape of that patch by, they say, Martin Storsjö (which he doesn't admit to be behind, I've talked to him). I don't know how his name came up what