[FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
I mistakenly used 'extradata' rather than 'st->codec->extradata', naturally leading to a segfault. Here's an updated patch. An explanation of the patch follows: Palettized QuickTime video in Matroska has hitherto not been recognized whatsoever, and the "palette" used has been completely random

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-23 Thread Mats Peterson
On 12/23/2015 03:37 PM, Mats Peterson wrote: I mistakenly used 'extradata' rather than 'st->codec->extradata', naturally leading to a segfault. Here's an updated patch. An explanation of the patch follows: Palettized QuickTime video in Matroska has hitherto not been recognized whatsoever, and t

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Michael Niedermayer
On Wed, Dec 23, 2015 at 03:37:18PM +0100, Mats Peterson wrote: > I mistakenly used 'extradata' rather than 'st->codec->extradata', > naturally leading to a segfault. Here's an updated patch. > > An explanation of the patch follows: > > Palettized QuickTime video in Matroska has hitherto not been

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Mats Peterson
On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return AVERROR(ENOMEM); the malloc is unneeded, an array on the stack could be used (its just a fixed 70 bytes) this would also simplify the error handling Yes, I thought so. I tried to be "a good

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Mats Peterson
On 12/27/2015 03:57 AM, Mats Peterson wrote: On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return AVERROR(ENOMEM); the malloc is unneeded, an array on the stack could be used (its just a fixed 70 bytes) this would also simplify the error handli

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Mats Peterson
On 12/27/2015 04:42 AM, Mats Peterson wrote: On 12/27/2015 03:57 AM, Mats Peterson wrote: On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return AVERROR(ENOMEM); the malloc is unneeded, an array on the stack could be used (its just a fixed 70 by

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-27 Thread Hendrik Leppkes
On Sun, Dec 27, 2015 at 4:42 AM, Mats Peterson wrote: > On 12/27/2015 03:57 AM, Mats Peterson wrote: >> >> On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return AVERROR(ENOMEM); >>> >>> >>> the malloc is unneeded, an array on the

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-27 Thread Mats Peterson
On 12/27/2015 10:30 AM, Hendrik Leppkes wrote: On Sun, Dec 27, 2015 at 4:42 AM, Mats Peterson wrote: On 12/27/2015 03:57 AM, Mats Peterson wrote: On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return AVERROR(ENOMEM); the malloc is unneeded

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-27 Thread Mats Peterson
On 12/27/2015 10:38 AM, Mats Peterson wrote: On 12/27/2015 10:30 AM, Hendrik Leppkes wrote: On Sun, Dec 27, 2015 at 4:42 AM, Mats Peterson wrote: On 12/27/2015 03:57 AM, Mats Peterson wrote: On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +ret

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-27 Thread wm4
On Sun, 27 Dec 2015 04:42:46 +0100 Mats Peterson wrote: > Actually I would prefer that nobody touches what I've been doing, since Saying this in an open source project... ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/