applied, as dbd7a84c814161926e5f298eae1f5ea17082f814, with an
additional check that AVFilterLink->type is AVMEDIA_TYPE_AUDIO before
calling av_get_sample_fmt_name() on AVFilterLink->format. Thanks for
pointing that out.
I will look into disabling auto-conversions when the filter is used
and removi
Le primidi 21 thermidor, an CCXXIV, Burt P. a écrit :
> Are you now talking about plans of the future or this specific case?
Both.
> As it is, automatic conversion is very helpful, for example from
> WavePack, which uses s16p.
Apparently, not all of them are to your liking. FFmpeg can not guess
Are you now talking about plans of the future or this specific case?
As it is, automatic conversion is very helpful, for example from
WavePack, which uses s16p.
This filter is only looking at the AVFilterLinks between filters, not
at the filters themselves.
This scan and warn behavior was added to
Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit :
> Wouldn't that disable any automatic conversion behind (after) the
> hdcd filter? If that is correct, I would not consider it a better solution.
The filter already checks for conversions after itself too.
Conversion can still happen,
Hi!
2016-08-07 23:50 GMT+02:00 Nicolas George :
> Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit :
>> I considered that acceptable but if better solutions exist (that are
>> also acceptable), I am happy.
>
> As I already pointed twice:
>
> /**
> * Enable or disable automatic format
Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit :
> I considered that acceptable but if better solutions exist (that are
> also acceptable), I am happy.
As I already pointed twice:
/**
* Enable or disable automatic format conversion inside the graph.
*
* Note that format conversio
2016-08-07 23:30 GMT+02:00 Nicolas George :
> Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit :
>> It would require the user to precisely declare what he wants which
>> is a good idea in this case because the filter can only work for
>> stereo s16 44100.
>
> No, it would not do that: t
Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit :
> It would require the user to precisely declare what he wants which
> is a good idea in this case because the filter can only work for
> stereo s16 44100.
No, it would not do that: there may be another filter in the chain that
forces
2016-08-07 23:07 GMT+02:00 Nicolas George :
> Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit :
>> i wanted to suggest since some time to remove sample_fmts_in[]
>> (that is responsible for a possibly auto-inserted resampler) and
>> instead error out if the input signal is not S16 (or
Le primidi 21 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit :
> i wanted to suggest since some time to remove sample_fmts_in[]
> (that is responsible for a possibly auto-inserted resampler) and
> instead error out if the input signal is not S16 (or S16P) 44100.
That would not work: the pixel form
2016-08-07 19:20 GMT+02:00 Nicolas George :
> Sorry if it has been addressed before, but what are these tests?
> Why is this filter invading other filters' privacy?
i wanted to suggest since some time to remove sample_fmts_in[]
(that is responsible for a possibly auto-inserted resampler) and
inste
Le primidi 21 thermidor, an CCXXIV, Burt P. a écrit :
> The HDCD codes are stored in the LSB of consecutive samples, and
> anything that would change a sample could cause problems. So it looks
> through the AVFilterLink chain and warns if any resampling or
> truncation is happening that might destr
On Sun, Aug 7, 2016 at 12:20 PM, Nicolas George wrote:
> Sorry if it has been addressed before, but what are these tests? Why is this
> filter invading other filters' privacy?
The HDCD codes are stored in the LSB of consecutive samples, and
anything that would change a sample could cause problems.
Le primidi 21 thermidor, an CCXXIV, Burt P a écrit :
> Signed-off-by: Burt P
> ---
> libavfilter/af_hdcd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c
> index e4e37e2..ebfe0f1 100644
> --- a/libavfilter/af_hdcd.c
> +++
Signed-off-by: Burt P
---
libavfilter/af_hdcd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c
index e4e37e2..ebfe0f1 100644
--- a/libavfilter/af_hdcd.c
+++ b/libavfilter/af_hdcd.c
@@ -1714,7 +1714,9 @@ static int config_input(
15 matches
Mail list logo
