Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-19 Thread Andreas Håkon
Hi Marton, Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Friday, 16 de August de 2019 10:27, Andreas Håkon wrote: > Hi Marton, > > ‐‐‐ Original Message ‐‐‐ > On Wednesday, 14 de August de 2019 23:31, Marton Balint c...@passwd.hu wrote: > > > I pushed this seri

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-16 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Wednesday, 14 de August de 2019 23:31, Marton Balint wrote: > I pushed this series, will post the patch which enables setting pcr period > for VBR. Great! I'll prepare my updated interleaved patch. Regards. A.H. ---

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-14 Thread Marton Balint
On Mon, 12 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 11 de August de 2019 22:14, Marton Balint wrote: > > +/* For VBR we select the highest multiple of frame duration which is less than 100 ms. */ > > Don't you think it's a good ide

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-12 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 11 de August de 2019 22:14, Marton Balint wrote: > > > +/* For VBR we select the highest multiple of frame duration > > > which is less than 100 ms. */ > > > > Don't you think it's a good idea to use the parameter "pcr_period"

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-11 Thread Marton Balint
On Sun, 11 Aug 2019, Andreas Håkon wrote: Hi Marton, > This new version LGTM. Thanks. I did a slight change for VBR streams and tried to mimic the old behaviour when selecting a PCR interval. Will post an updated version, but that should only affect VBR. Regarding this new VBR patch I

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-11 Thread Andreas Håkon
Hi Marton, > > This new version LGTM. > Thanks. I did a slight change for VBR streams and tried to mimic the old > behaviour when selecting a PCR interval. Will post an updated version, but > that should only affect VBR. Regarding this new VBR patch I have one comment... ‐‐‐ Original Mess

[FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-10 Thread Marton Balint
PCR generation was based on counting packets for both CBR and VBR streams. Couting packets might have worked for CBR streams (when muxrate was specified) but it only took into account the packets of a service (or the packets of the PCR stream lately), so even that was problematic for multi program