Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-22 Thread Timo Rothenpieler
Am 04.09.2017 um 14:59 schrieb Yogender Gupta: Taken care of all comments except the documentation. applied Will send out a separate patch for both the CUDA filters documentation. ok smime.p7s Description: S/MIME Cryptographic Signature ___ ffm

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-13 Thread Rostislav Pehlivanov
On 13 September 2017 at 19:12, Timo Rothenpieler wrote: > I did object and have NAK'd the patch currently. >> Make the submitter submit a new version themselves and I'll approve it. >> > > There was a new version submitted already, I just replied to the wrong one. > > > __

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-13 Thread Timo Rothenpieler
I did object and have NAK'd the patch currently. Make the submitter submit a new version themselves and I'll approve it. There was a new version submitted already, I just replied to the wrong one. smime.p7s Description: S/MIME Cryptographic Signature __

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-13 Thread Rostislav Pehlivanov
On 13 September 2017 at 14:43, Timo Rothenpieler wrote: > Will apply with some minor changes (some unused variables are still left, > and some cleanup is missing) soon if nobody objects. > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-13 Thread Timo Rothenpieler
Will apply with some minor changes (some unused variables are still left, and some cleanup is missing) soon if nobody objects. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-11 Thread Timo Rothenpieler
It would be nice, yes, but I'm not sure there is actually that much need with the current setup. The use-cases for the two as currently written don't really overlap - CUDA is useful in the cases you describe with (possibly multiple) high-power GPUs trying to squeeze as much performance as poss

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-11 Thread Mark Thompson
On 11/09/17 10:18, Timo Rothenpieler wrote: > Am 11.09.2017 um 07:40 schrieb Yogender Gupta: Only 3 to 4 times? This is easily doable with SIMD. >> >> The problem is not with the thumbnail filter at all. The problem is doing >> the transfers from vidmem to sysmem or vice-versa. You will obser

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-11 Thread Timo Rothenpieler
Am 11.09.2017 um 07:40 schrieb Yogender Gupta: Only 3 to 4 times? This is easily doable with SIMD. The problem is not with the thumbnail filter at all. The problem is doing the transfers from vidmem to sysmem or vice-versa. You will observe if we use a transcoder pipeline with and without hwa

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-10 Thread Yogender Gupta
gender -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Rostislav Pehlivanov Sent: Monday, September 11, 2017 10:56 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter On 11 September 2017 at

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-10 Thread Rostislav Pehlivanov
On 11 September 2017 at 05:59, Yogender Gupta wrote: > I believe there were concerns on pushing the CUDA thumbnail filter and > that is possible to get similar performance using the normal thumbnail > filter. The CUDA thumbnail filter is useful for generating thumbnails on > the hwaccel cuvid pip

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-10 Thread Yogender Gupta
I believe there were concerns on pushing the CUDA thumbnail filter and that is possible to get similar performance using the normal thumbnail filter. The CUDA thumbnail filter is useful for generating thumbnails on the hwaccel cuvid pipeline, as it can directly operate on the video memory and gi

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread wm4
On Mon, 4 Sep 2017 20:41:19 +0100 Rostislav Pehlivanov wrote: > On 4 September 2017 at 19:44, wm4 wrote: > > > On Mon, 4 Sep 2017 19:07:02 +0100 > > Rostislav Pehlivanov wrote: > > > > > On 4 September 2017 at 18:18, wm4 wrote: > > > > > > > On Mon, 4 Sep 2017 18:03:51 +0100 > > > > Rosti

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread Rostislav Pehlivanov
On 4 September 2017 at 19:44, wm4 wrote: > On Mon, 4 Sep 2017 19:07:02 +0100 > Rostislav Pehlivanov wrote: > > > On 4 September 2017 at 18:18, wm4 wrote: > > > > > On Mon, 4 Sep 2017 18:03:51 +0100 > > > Rostislav Pehlivanov wrote: > > > > > > > On 4 September 2017 at 17:25, Timo Rothenpieler

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread wm4
On Mon, 4 Sep 2017 19:07:02 +0100 Rostislav Pehlivanov wrote: > On 4 September 2017 at 18:18, wm4 wrote: > > > On Mon, 4 Sep 2017 18:03:51 +0100 > > Rostislav Pehlivanov wrote: > > > > > On 4 September 2017 at 17:25, Timo Rothenpieler > > > wrote: > > > > > > > We have av_pixelutils_sad_f

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread Rostislav Pehlivanov
On 4 September 2017 at 18:18, wm4 wrote: > On Mon, 4 Sep 2017 18:03:51 +0100 > Rostislav Pehlivanov wrote: > > > On 4 September 2017 at 17:25, Timo Rothenpieler > > wrote: > > > > > We have av_pixelutils_sad_fn which does SAD and has SIMD, there's no > point > > >> in reinventing the wheel. > >

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread wm4
On Mon, 4 Sep 2017 18:03:51 +0100 Rostislav Pehlivanov wrote: > On 4 September 2017 at 17:25, Timo Rothenpieler > wrote: > > > We have av_pixelutils_sad_fn which does SAD and has SIMD, there's no point > >> in reinventing the wheel. > >> > >> I also don't see why this needs to be implemented

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread Rostislav Pehlivanov
On 4 September 2017 at 17:25, Timo Rothenpieler wrote: > We have av_pixelutils_sad_fn which does SAD and has SIMD, there's no point >> in reinventing the wheel. >> >> I also don't see why this needs to be implemented with CUDA. You're not >> even doing the SAD in CUDA. I bet it'll be just as fast

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread Timo Rothenpieler
We have av_pixelutils_sad_fn which does SAD and has SIMD, there's no point in reinventing the wheel. I also don't see why this needs to be implemented with CUDA. You're not even doing the SAD in CUDA. I bet it'll be just as fast if not faster in C (unless you cheat somehow). The point is to do

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread Rostislav Pehlivanov
On 30 August 2017 at 05:19, Yogender Gupta wrote: > Attached is a CUDA version of the thumbnail filter, this helps accelerate > thumbnails generations significantly, when using the GPU pipeline. > > Regards, > Yogender > > > ---

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-04 Thread Yogender Gupta
Taken care of all comments except the documentation. Will send out a separate patch for both the CUDA filters documentation. Regards, Yogender --- This email message is for the sole use of the intended recipient(s) a

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-01 Thread Timo Rothenpieler
Also missing a dep on cuda_sdk in configure. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-01 Thread Timo Rothenpieler
Am 30.08.2017 um 06:19 schrieb Yogender Gupta: Attached is a CUDA version of the thumbnail filter, this helps accelerate thumbnails generations significantly, when using the GPU pipeline. Regards, Yogender After having a look at the code: The filter is using a global "CUdeviceptr data;" vari

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-08-30 Thread Timo Rothenpieler
Am 30.08.2017 um 06:19 schrieb Yogender Gupta: Attached is a CUDA version of the thumbnail filter, this helps accelerate thumbnails generations significantly, when using the GPU pipeline. Without having done a full review on the code yet: A new filter needs a libavfilter version bump(not 100%

[FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-08-29 Thread Yogender Gupta
Attached is a CUDA version of the thumbnail filter, this helps accelerate thumbnails generations significantly, when using the GPU pipeline. Regards, Yogender --- This email message is for the sole use of the intende