Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Marton Balint
On Fri, 5 May 2017, Carl Eugen Hoyos wrote: 2017-05-05 9:57 GMT+02:00 Aaron Levinson : You hadn't previously indicated that the warnings disappeared when 23 is used, so I was operating based on the warning text, which said that the output text could consume as much as

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 9:57 GMT+02:00 Aaron Levinson : > You hadn't previously indicated that the warnings disappeared > when 23 is used, so I was operating based on the warning text, > which said that the output text could consume as much as 32 > bytes. It seems odd that the warning

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 9:57 GMT+02:00 Aaron Levinson : How can I reproduce / test your findings? >>> >>> #define AV_TIMECODE_STR_SIZE 32 or 33 and confirm >>> that gcc 7 warnings go away. >> >> Of course! >> Since the warnings go away with 23, they also go away with 32. >> I just

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:44 AM, Carl Eugen Hoyos wrote: 2017-05-05 9:42 GMT+02:00 Aaron Levinson : On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson : On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Clément Bœsch
On Fri, May 05, 2017 at 09:44:46AM +0200, Carl Eugen Hoyos wrote: > 2017-05-05 9:42 GMT+02:00 Aaron Levinson : > > On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: > >> > >> 2017-05-05 3:29 GMT+02:00 Aaron Levinson : > >>> > >>> On 5/4/2017 4:27 PM, Carl

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson : On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In function

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 3:29 GMT+02:00 Aaron Levinson : > On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: >> >> Hi! >> >> Attached patch is one possibility to fix the following warning with gcc 7: >> libavutil/timecode.c: In function ‘av_timecode_make_string’: >> libavutil/timecode.c:103:60:

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-04 Thread Aaron Levinson
On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In function ‘av_timecode_make_string’: libavutil/timecode.c:103:60: warning: ‘%02d’ directive output may be truncated writing between 2 and 10 bytes

[FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-04 Thread Carl Eugen Hoyos
Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In function ‘av_timecode_make_string’: libavutil/timecode.c:103:60: warning: ‘%02d’ directive output may be truncated writing between 2 and 10 bytes into a region of size between 0 and 7