Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Michael Fritscher
Hi, master uses _WIN32 checks in both places so if its not set, it will never error, because it'll never even try to call it. 3.1 uses a different check because it was refactored in master later, and while 3.1.3 was still missing one check, it was fixed after that release was made. Unless master

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Tobias Rapp
On 22.09.2016 14:23, Hendrik Leppkes wrote: On Thu, Sep 22, 2016 at 2:21 PM, Timo Rothenpieler wrote: master uses _WIN32 checks in both places so if its not set, it will never error, because it'll never even try to call it. But wasn't the HAVE_SETDLLDIRECTORY introduced because of Windows XP

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Hendrik Leppkes
On Thu, Sep 22, 2016 at 2:21 PM, Timo Rothenpieler wrote: >> master uses _WIN32 checks in both places so if its not set, it will >> never error, because it'll never even try to call it. > > But wasn't the HAVE_SETDLLDIRECTORY introduced because of Windows XP > compatibility, as the function doesn'

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Timo Rothenpieler
> master uses _WIN32 checks in both places so if its not set, it will > never error, because it'll never even try to call it. But wasn't the HAVE_SETDLLDIRECTORY introduced because of Windows XP compatibility, as the function doesn't exist there, but _WIN32 is obviously set? Or does master just n

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Hendrik Leppkes
On Thu, Sep 22, 2016 at 1:52 PM, Timo Rothenpieler wrote: > Am 22.09.2016 um 13:37 schrieb Michael Fritscher: >> Hi, >> >> ok, I rephrase it: I have the issue that HAVE_SETDLLDIRECTORY is >> defined, but _WIN32 is not if compiling under cygwin (fresh install, no >> mingw). >> >> SetDllDirectory()

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Timo Rothenpieler
Am 22.09.2016 um 13:37 schrieb Michael Fritscher: > Hi, > > ok, I rephrase it: I have the issue that HAVE_SETDLLDIRECTORY is > defined, but _WIN32 is not if compiling under cygwin (fresh install, no > mingw). > > SetDllDirectory() is called whenever HAVE_SETDLLDIRECTORY is defined, > there is no

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Michael Fritscher
Hi, ok, I rephrase it: I have the issue that HAVE_SETDLLDIRECTORY is defined, but _WIN32 is not if compiling under cygwin (fresh install, no mingw). SetDllDirectory() is called whenever HAVE_SETDLLDIRECTORY is defined, there is no check for _WIN32. The configure script seems to test window

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Tobias Rapp
On 22.09.2016 12:30, Michael Fritscher wrote: Hi, I try to build ffmpeg 3.1.3 on cygwin64 on Windows. Configstring: ./configure --prefix=/usr/local --enable-ffplay --enable-ffmpeg --enable-ffserver --enable-gpl --enable-version3 --enable-nonfree --enable-shared --enable-libfreetype --enable-lib

Re: [FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Hendrik Leppkes
On Thu, Sep 22, 2016 at 12:30 PM, Michael Fritscher wrote: > Hi, > > I try to build ffmpeg 3.1.3 on cygwin64 on Windows. > > Configstring: ./configure --prefix=/usr/local --enable-ffplay > --enable-ffmpeg --enable-ffserver --enable-gpl --enable-version3 > --enable-nonfree --enable-shared --enable-

[FFmpeg-devel] [RFC FIX] Build error with ffmpeg 3.1.3 (and current git) on cygwin

2016-09-22 Thread Michael Fritscher
Hi, I try to build ffmpeg 3.1.3 on cygwin64 on Windows. Configstring: ./configure --prefix=/usr/local --enable-ffplay --enable-ffmpeg --enable-ffserver --enable-gpl --enable-version3 --enable-nonfree --enable-shared --enable-libfreetype --enable-libgsm --enable-libmp3lame --enable-libopencv -