In Chromium code, we set s->metadata ahead of time, with a custom entry to
avoid id3v1 tag parsing.
Some recent changes in mp3dec.c meant that we had to update this code, and
in the process, we discovered this reference leak on our end.
I am submitting this patch as a general code hardening patch
On Thu, 6 Apr 2017 14:07:53 -0700
Thomas Guilbert wrote:
> The patch didn't show up as properly formatted on
> https://patchwork.ffmpeg.org/patch/3228/.
>
> Re-submitting using no line wrap in the base64 attachment, and copying the
> contents of the patch for ease of review:
>
> From fced5ab0e0
The patch didn't show up as properly formatted on
https://patchwork.ffmpeg.org/patch/3228/.
Re-submitting using no line wrap in the base64 attachment, and copying the
contents of the patch for ease of review:
>From fced5ab0e09f529397adddcb560d1a08f2df4840 Mon Sep 17 00:00:00 2001
From: Thomas Gui
Commit '65862f57ad2f7f49d715f334a9d892e0b20d42f1' overwrites s->metada
with s->internal->id3v2_meta, which leaks an AVDictionary* if
s->metada was not null.
Please excuse any formatting problems in this email, this is my first
time uploading a patch :)
Thank you,
Thomas
RnJvbSBmY2VkNWFiMGUwOWY1Mj