Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-19 Thread Ronald S. Bultje
Hi On Wed, Aug 19, 2015 at 9:45 AM, Pedro Arthur wrote: > patch committed. Nice work! Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-19 Thread Pedro Arthur
patch committed. 2015-08-19 7:11 GMT-03:00 Michael Niedermayer : > On Tue, Aug 18, 2015 at 11:36:16PM -0300, Pedro Arthur wrote: > > Added copyright. > > I've tried to push it (git push ffmpeg master --dry-run) but got the > > following error: > > fatal: remote error: access denied or repository

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-19 Thread Michael Niedermayer
On Tue, Aug 18, 2015 at 11:36:16PM -0300, Pedro Arthur wrote: > Added copyright. > I've tried to push it (git push ffmpeg master --dry-run) but got the > following error: > fatal: remote error: access denied or repository not exported: /ffmpeg.git > with remote: > ffmpeggit+ssh://source.ffmpeg.

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-19 Thread Michael Niedermayer
On Tue, Aug 18, 2015 at 11:36:16PM -0300, Pedro Arthur wrote: > Added copyright. > I've tried to push it (git push ffmpeg master --dry-run) but got the > following error: > fatal: remote error: access denied or repository not exported: /ffmpeg.git > with remote: > ffmpeggit+ssh://source.ffmpeg.

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-18 Thread Pedro Arthur
Added copyright. I've tried to push it (git push ffmpeg master --dry-run) but got the following error: fatal: remote error: access denied or repository not exported: /ffmpeg.git with remote: ffmpeggit+ssh://source.ffmpeg.org/ffmpeg.git (fetch) ffmpeggit+ssh://source.ffmpeg.org/ffmpeg.git (p

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-18 Thread James Almer
On 18/08/15 6:30 PM, Pedro Arthur wrote: > diff --git a/libswscale/vscale.c b/libswscale/vscale.c > new file mode 100644 > index 000..b62b385 > --- /dev/null > +++ b/libswscale/vscale.c > @@ -0,0 +1,268 @@ > +#include "swscale_internal.h" > + > +static int lum_planar_vscale(SwsContext *c, SwsFi

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-18 Thread Michael Niedermayer
On Tue, Aug 18, 2015 at 06:30:28PM -0300, Pedro Arthur wrote: > Patch with alpha fixed. > > 2015-08-18 18:07 GMT-03:00 Michael Niedermayer : > > > On Tue, Aug 18, 2015 at 04:27:42PM -0300, Pedro Arthur wrote: > > > Attached patch with new vertical scaler code, added license and fixed > > > compil

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-18 Thread Pedro Arthur
Patch with alpha fixed. 2015-08-18 18:07 GMT-03:00 Michael Niedermayer : > On Tue, Aug 18, 2015 at 04:27:42PM -0300, Pedro Arthur wrote: > > Attached patch with new vertical scaler code, added license and fixed > > compiler warnings. > > > split and applied first patch, had to change 2 asserts to

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-18 Thread Michael Niedermayer
On Tue, Aug 18, 2015 at 04:27:42PM -0300, Pedro Arthur wrote: > Attached patch with new vertical scaler code, added license and fixed > compiler warnings. split and applied first patch, had to change 2 asserts to make it work without the vscale code [...] -- Michael GnuPG fingerprint: 9FF2

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-18 Thread Michael Niedermayer
On Tue, Aug 18, 2015 at 04:27:42PM -0300, Pedro Arthur wrote: > Attached patch with new vertical scaler code, added license and fixed > compiler warnings. the vscaler works much better now than prevously, theres one bug left in it though ./ffplay ./laraShadow_dl.flv -vf scale=400x400:flags=16,fo

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-18 Thread Pedro Arthur
Attached patch with new vertical scaler code, added license and fixed compiler warnings. 2015-08-17 20:35 GMT-03:00 Michael Niedermayer : > On Mon, Aug 17, 2015 at 05:35:32PM -0300, Pedro Arthur wrote: > > ops, added missing file. > > > > > > 2015-08-17 17:31 GMT-03:00 Pedro Arthur : > > > > > >

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-17 Thread Michael Niedermayer
On Mon, Aug 17, 2015 at 05:35:32PM -0300, Pedro Arthur wrote: > ops, added missing file. > > > 2015-08-17 17:31 GMT-03:00 Pedro Arthur : > > > > > > > 2015-08-17 0:19 GMT-03:00 Michael Niedermayer : > > > >> also feel free to split the batch addition into a seperate commit > >> (should be easy a

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-17 Thread Pedro Arthur
ops, added missing file. 2015-08-17 17:31 GMT-03:00 Pedro Arthur : > > > 2015-08-17 0:19 GMT-03:00 Michael Niedermayer : > >> also feel free to split the batch addition into a seperate commit >> (should be easy as you already have a versionn with and without) >> > Attached proper patchs. > > als

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-17 Thread Pedro Arthur
2015-08-17 0:19 GMT-03:00 Michael Niedermayer : > also feel free to split the batch addition into a seperate commit > (should be easy as you already have a versionn with and without) > Attached proper patchs. also, please send me your public ssh key, i think you should have > direct write access

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-16 Thread Michael Niedermayer
On Sun, Aug 16, 2015 at 07:13:07PM -0300, Pedro Arthur wrote: > 2015-08-15 7:24 GMT-03:00 Michael Niedermayer : > > > these are not git patches > > > Yes, they are raw git diffs. > > > > > > A - New code > > > > doesnt compile (but that doesnt matter as you say this is slower anyway) > > libswsca

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-16 Thread Pedro Arthur
2015-08-15 7:24 GMT-03:00 Michael Niedermayer : > these are not git patches > Yes, they are raw git diffs. > > > A - New code > > doesnt compile (but that doesnt matter as you say this is slower anyway) > libswscale/swscale.c: In function ‘swscale’: > libswscale/swscale.c:529:18: error: ‘i’ undec

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-15 Thread Michael Niedermayer
On Sat, Aug 15, 2015 at 12:17:27AM -0300, Pedro Arthur wrote: > Hi, > Since the last patch I was trying to improve the performance regression. > First I tried to process horizontal lines in batches, processing > (horizontal_filter_size + n) > lines at a time. I also tried to remove branch code from

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-11 Thread Michael Niedermayer
On Tue, Aug 11, 2015 at 03:17:55PM -0300, Pedro Arthur wrote: > Hi, > > The past week I worked on refactoring the vertical scaler code. > The vertical scaler was not split in scaling pass and color conversion pass > (as the horizontal scaler) > because the output functions currently merge these pa

[FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-11 Thread Pedro Arthur
Hi, The past week I worked on refactoring the vertical scaler code. The vertical scaler was not split in scaling pass and color conversion pass (as the horizontal scaler) because the output functions currently merge these passes and it would require rewriting all these functions. This week I shoul

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-08-05 Thread Pedro Arthur
New patch with the green line bug fixed. Now I intend to speedup the work on the vertical scaling and also try to reduce the performance gap. 2015-07-29 10:05 GMT-03:00 Michael Niedermayer : > On Tue, Jul 28, 2015 at 11:39:59PM -0300, Pedro Arthur wrote: > > > do you think this patch would be rea

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-07-29 Thread Michael Niedermayer
On Tue, Jul 28, 2015 at 11:39:59PM -0300, Pedro Arthur wrote: > > do you think this patch would be ready to push to main ffmpeg once > > this (and any other remaining) issues are fixed > > or is there still some speed loss ? > > > I think I should work a bit more on it, in my tests some cases there

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-07-28 Thread Pedro Arthur
> do you think this patch would be ready to push to main ffmpeg once > this (and any other remaining) issues are fixed > or is there still some speed loss ? > I think I should work a bit more on it, in my tests some cases there is still 3% speed loss. Usualy it occurs when the vertical filter size

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-07-28 Thread Michael Niedermayer
On Tue, Jul 28, 2015 at 06:06:04PM -0300, Pedro Arthur wrote: > All these weird bugs were caused by the mmx code expecting the chroma U > and V buffer to be contiguous in memory. As I was allocating the slice > lines U > and V separately the mmx code was using some random memory. > In the attached

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-07-28 Thread Pedro Arthur
All these weird bugs were caused by the mmx code expecting the chroma U and V buffer to be contiguous in memory. As I was allocating the slice lines U and V separately the mmx code was using some random memory. In the attached patch there is a fix for it. I also added some documentation to the new

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-07-23 Thread Pedro Arthur
> ./ffplay -f lavfi testsrc -vf format=yvyu422,scale=flags=1 (black > screen) > I'm working on a proper fix for it (I did a workaround for the first bug that also solves it) > ./ffplay -f lavfi testsrc -vf format=rgb555 (gray and some odd distortion) > This I'll have to check. _

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-07-22 Thread Michael Niedermayer
On Wed, Jul 22, 2015 at 10:49:38AM -0300, Pedro Arthur wrote: > Last week I worked on fixing the following > * Memory allocation checks > * Code style > I also investigated the ffplay bug (./ffplay -f lavfi testsrc -vf > format=yuvj420p) which presents a grey screen. It still not fixed in this > pa

[FFmpeg-devel] GSoC Weekly report (libswscale)

2015-07-22 Thread Pedro Arthur
Last week I worked on fixing the following * Memory allocation checks * Code style I also investigated the ffplay bug (./ffplay -f lavfi testsrc -vf format=yuvj420p) which presents a grey screen. It still not fixed in this patch but I already found the cause and I intend to fix in the next patch.

[FFmpeg-devel] GSoC Weekly Report (libswscale refactor)

2015-07-01 Thread Pedro Arthur
Hi, The past week I spent most of the time working in a fix for the crash when using ./ffmpeg -i lena.pnm -vf format=gbrp test.avi I'm now working in the line pool and ring buffer. Soon I should send a patch which fixes the crash and one for the line pool e ring buffer implementation. ___

Re: [FFmpeg-devel] GSoC Weekly Report (libswscale refactor)

2015-06-25 Thread wm4
On Thu, 25 Jun 2015 13:34:57 -0300 Pedro Arthur wrote: > > it passes fate but seems to crash for example with: > > ./ffmpeg -i lena.pnm -vf format=gbrp test.avi > > > I'll check it. > > how /over what did you meassure the 3% exactly ? > > iam asking, so i understand if this performance chnage i

Re: [FFmpeg-devel] GSoC Weekly Report (libswscale refactor)

2015-06-25 Thread Pedro Arthur
> it passes fate but seems to crash for example with: > ./ffmpeg -i lena.pnm -vf format=gbrp test.avi > I'll check it. how /over what did you meassure the 3% exactly ? > iam asking, so i understand if this performance chnage is irrelevant > or not. > for init code that runs once some speed loss i

Re: [FFmpeg-devel] GSoC Weekly Report (libswscale refactor)

2015-06-24 Thread Michael Niedermayer
On Wed, Jun 24, 2015 at 02:41:54PM -0300, Pedro Arthur wrote: > Hi, > > I'm working on the libswscale refactoring and Michael advised me to send > the changes to the > mailing list so that I can get more feedback about it. Thus I added the > references [1] - [7] which > are links to commits on my

[FFmpeg-devel] GSoC Weekly Report (libswscale refactor)

2015-06-24 Thread Pedro Arthur
Hi, I'm working on the libswscale refactoring and Michael advised me to send the changes to the mailing list so that I can get more feedback about it. Thus I added the references [1] - [7] which are links to commits on my github fork of FFmpeg. Last week I wrote the horizontal chroma scaling (pat