Re: [FFmpeg-devel] Question regarding ogg cover art implementation

Isn't reading already supported? See ff_vorbis_comment in libavformat/oggparsevorbis.c. (These functions use one buffer too much which could be easily avoided.) Ah seems like I missed that. Thanks for pointing that out! Saved me some time trying to figure out if I needed to touch that at all.

Re: [FFmpeg-devel] Question regarding ogg cover art implementation

Jesse Obic: > Hi, > > First time using a mailing list and (properly) working with C, so please > forgive me if I've done something wrong. > > I'm looking at implementing https://trac.ffmpeg.org/ticket/4448 > , and I understand what I need to > do but I'm on th

Re: [FFmpeg-devel] Question regarding ogg cover art implementation

On 23/08/2021 12:04 pm, Chad Fraleigh wrote: Would allocating 16M really be a lot, given typically there wouldn't be many of them? That's something I wanted to get clarification on. I've seen ffmpeg's libraries used in embedded hardware / environments with restricted memory; however I'm not s

Re: [FFmpeg-devel] Question regarding ogg cover art implementation

On 8/22/2021 4:49 PM, Jesse Obic wrote: I'm looking at implementing https://trac.ffmpeg.org/ticket/4448 , and I understand what I need to do but I'm on the fence about how I should go about doing it. For the OGG container, cover art is embedded into the fi

[FFmpeg-devel] Question regarding ogg cover art implementation

Hi, First time using a mailing list and (properly) working with C, so please forgive me if I've done something wrong. I'm looking at implementing https://trac.ffmpeg.org/ticket/4448 , and I understand what I need to do but I'm on the fence about how I sho