Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-24 Thread Clément Bœsch
On Fri, Jan 23, 2015 at 06:44:56AM -0800, jon wrote: > Hi Michael, > > That is great! > > I see what you are referring to in mov_read_timecode_track(). However the > text of that comment seems contradictory to me based on what I have read in > the QuickTime reference I sited about the tmcd counte

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-23 Thread jon
Hi Michael, That is great! I see what you are referring to in mov_read_timecode_track(). However the text of that comment seems contradictory to me based on what I have read in the QuickTime reference I sited about the tmcd counter flag. It seemed like prior to the patch I submitted mov_pars

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-23 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 04:26:59AM +0100, Michael Niedermayer wrote: > On Thu, Jan 22, 2015 at 09:09:53AM -0800, jon wrote: > > I never heard back about this and I think I have a new better > > are you subscribed to ffmpeg-devel ? > > > > solution now. I don't think the current mov.c timecode pr

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-22 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 09:09:53AM -0800, jon wrote: > I never heard back about this and I think I have a new better are you subscribed to ffmpeg-devel ? > solution now. I don't think the current mov.c timecode processing is > handling the case where the timecode is in counter mode. Please read

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-22 Thread jon
I never heard back about this and I think I have a new better solution now. I don't think the current mov.c timecode processing is handling the case where the timecode is in counter mode. Please read the following page 190 from: https://developer.apple.com/library/mac/documentation/QuickTime/Q

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2014-09-09 Thread Michael Niedermayer
On Tue, Sep 09, 2014 at 12:01:23PM -0700, jon wrote: > Hi ffmpeg developers. > > I am still new to attempting contributing here, so please let me > know if there is a better approach for this. I am attaching a patch > I would like to incorporate for calculating the stream time_base of > the timeco

[FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2014-09-09 Thread jon
Hi ffmpeg developers. I am still new to attempting contributing here, so please let me know if there is a better approach for this. I am attaching a patch I would like to incorporate for calculating the stream time_base of the timecode data track in mov's. Please advise. Thanks! >From 5ae0b5