Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:40:03AM +0200, Nicolas Martyanoff wrote: > The FFmpeg developer info page said it was fine to use github instead of > mailing patches, but if you prefer, I can mail them. pull requests are more intended for code after it has been reviewed by someone who knows the code we

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Nicolas Martyanoff
The FFmpeg developer info page said it was fine to use github instead of mailing patches, but if you prefer, I can mail them. -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Stefano Sabatini
On date Friday 2014-07-18 10:07:21 +0200, Nicolas Martyanoff encoded: > Hi, > > Any chance someone could take a look to these patches ? Could you send them to this mailing-list? This way we will be able to make a proper inline review, thanks. -- FFmpeg = Fundamentalist & Freak Mysterious Power

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-18 Thread Nicolas Martyanoff
Hi, Any chance someone could take a look to these patches ? -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-11 Thread Nicolas Martyanoff
I updated my pull request, taking the comments of Anssi Hannula into account, and splitting patches as much as possible. Contact me if there is any trouble. -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-10 Thread Nicolas Martyanoff
On 2014-07-10 03:36, Anssi Hannula wrote: > 10.07.2014 02:40, Nicolas Martyanoff kirjoitti: > > On 2014-07-10 01:32, Anssi Hannula wrote: > >> avformat/hlsenc: cleaning > >> - looks good to me, and there is no maintainer so I guess this is OK > >> - well, actually, maybe you could use more than one

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Anssi Hannula
10.07.2014 02:40, Nicolas Martyanoff kirjoitti: > On 2014-07-10 01:32, Anssi Hannula wrote: >> avformat/hlsenc: cleaning >> - looks good to me, and there is no maintainer so I guess this is OK >> - well, actually, maybe you could use more than one word in the subject :) > I'll change the title to s

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
On 2014-07-10 01:32, Anssi Hannula wrote: > avformat/hlsenc: cleaning > - looks good to me, and there is no maintainer so I guess this is OK > - well, actually, maybe you could use more than one word in the subject :) I'll change the title to something such as 'make the code easier to read' :) > a

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Anssi Hannula
09.07.2014 12:26, Nicolas Martyanoff kirjoitti: > Hi, Hi, and thanks for the patches. > The hlsenc muxer only supports HLS version 3, and I needed byterange support > (version 4), so I added it :) > > You will find a pull request on Github (hlsenc branch): > > https://github.com/FFmpeg/FFmpeg/p

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
I added a new patch to the pull request, introducing a '-hls_media_filename' option to provide a filename (in single file mode) or a filename pattern (in default mode). https://github.com/galdor/FFmpeg/commit/cd45075eed0444ae0fd2410a8784bc472b315341 -- Nicolas Martyanoff http://wandrian.net khae

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
I added a new patch to the pull request, introducing a flag to disable filenames in segment names: https://github.com/galdor/FFmpeg/commit/246bccaee75aea8ae5a46145bb38ff8071e5f6ef -- Nicolas Martyanoff http://wandrian.net khae...@gmail.com ___ ffmpeg-d

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
On 2014-07-09 10:09, Carl Eugen Hoyos wrote: > Nicolas Martyanoff gmail.com> writes: > > > default subtitles format > > This patch is not ok (just reencode a random file > with subtitles to find out) You are right, you cannot just transcode a dvdsub stream into a webvtt one. I'll remove the pa

Re: [FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Carl Eugen Hoyos
Nicolas Martyanoff gmail.com> writes: > default subtitles format This patch is not ok (just reencode a random file with subtitles to find out) and I don't think "HLS streams must use the WebVTT subtitle format." is true. Carl Eugen ___ ffmpeg-deve

[FFmpeg-devel] avformat/hlsenc: pull request for single file mode

2014-07-09 Thread Nicolas Martyanoff
Hi, The hlsenc muxer only supports HLS version 3, and I needed byterange support (version 4), so I added it :) You will find a pull request on Github (hlsenc branch): https://github.com/FFmpeg/FFmpeg/pull/76 There are four patches. Two fix small issues in the muxer (target duration computation