Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-03-14 Thread Jerome Martinez
On 10/03/2023 22:10, Marton Balint wrote: On Mon, 6 Mar 2023, Nicolas Gaullier wrote: [...] Some weeks later now and no replies, maybe time to go on ? I think the "case AV_CODEC_ID_DVVIDEO:" can be removed as discussed, fate updated and that should be ok for everybody. (Ideally, it could ha

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-03-13 Thread Pierre-Anthony Lemieux
On Mon, Mar 13, 2023 at 3:30 PM Marton Balint wrote: > > > > On Fri, 10 Mar 2023, Marton Balint wrote: > > > > > > > On Mon, 6 Mar 2023, Nicolas Gaullier wrote: > > > > The width is one thing; for whatever reason, there is a divergence > > between DV100 on one hand and AVCI/XDCAMHD35 on

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-03-13 Thread Marton Balint
On Fri, 10 Mar 2023, Marton Balint wrote: On Mon, 6 Mar 2023, Nicolas Gaullier wrote: The width is one thing; for whatever reason, there is a divergence between DV100 on one hand and AVCI/XDCAMHD35 on the other. In my understanding, in current practices, DV obey s337 (stored width incl

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-03-10 Thread Marton Balint
On Mon, 6 Mar 2023, Nicolas Gaullier wrote: The width is one thing; for whatever reason, there is a divergence between DV100 on one hand and AVCI/XDCAMHD35 on the other. In my understanding, in current practices, DV obey s337 (stored width includes scaling) but >xdcam&avci does not, so curre

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-03-06 Thread Nicolas Gaullier
>>> The width is one thing; for whatever reason, there is a divergence between >>> DV100 on one hand and AVCI/XDCAMHD35 on the other. In my understanding, in >>> current practices, DV obey s337 (stored width includes scaling) but >>> >xdcam&avci does not, so current code is fine >but maybe this

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-18 Thread Tomas Härdin
mån 2023-01-16 klockan 15:28 +0100 skrev Jerome Martinez: > On 16/01/2023 14:50, Tomas Härdin wrote: > > lör 2023-01-14 klockan 16:48 +0100 skrev Jerome Martinez: > > > Before the patch: > > > - stored values were rounded to upper 16 multiple also for > > > formats > > > not > > > using macroblocks

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Nicolas Gaullier
>> The width is one thing; for whatever reason, there is a divergence between >> DV100 on one hand and AVCI/XDCAMHD35 on the other. In my understanding, in >> current practices, DV obey s337 (stored width includes scaling) but >> >xdcam&avci does not, so current code is fine but maybe this is an

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Jerome Martinez
On 16/01/2023 15:00, Nicolas Gaullier wrote: Before the patch: - stored values were rounded to upper 16 multiple also for formats not using macroblocks (should be st->codecpar->width and st->codecpar->height when not MPEG formats; note that I found no other muxer doing the rounding for AVC, only

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Jerome Martinez
On 16/01/2023 14:50, Tomas Härdin wrote: lör 2023-01-14 klockan 16:48 +0100 skrev Jerome Martinez: Before the patch: - stored values were rounded to upper 16 multiple also for formats not using macroblocks (should be st->codecpar->width and st->codecpar->height when not MPEG formats; note that I

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Nicolas Gaullier
>Before the patch: >- stored values were rounded to upper 16 multiple also for formats not using >macroblocks (should be st->codecpar->width and >st->codecpar->height when not MPEG formats; note that I found no other >muxer doing the rounding for AVC, only for MPEG-2 Video, but I find no reason

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-16 Thread Tomas Härdin
lör 2023-01-14 klockan 16:48 +0100 skrev Jerome Martinez: > Before the patch: > - stored values were rounded to upper 16 multiple also for formats > not > using macroblocks (should be st->codecpar->width and > st->codecpar->height when not MPEG formats; note that I found no > other > muxer doing

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-15 Thread Michael Niedermayer
On Sun, Jan 15, 2023 at 03:24:37PM +0100, Jerome Martinez wrote: > On 14/01/2023 21:04, Michael Niedermayer wrote: > > On Sat, Jan 14, 2023 at 04:48:10PM +0100, Jerome Martinez wrote: > > [...] > > > +stored_height = (stored_height+15)/16*16; > > If this is supposed to match the actual macr

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-15 Thread Jerome Martinez
On 14/01/2023 21:04, Michael Niedermayer wrote: On Sat, Jan 14, 2023 at 04:48:10PM +0100, Jerome Martinez wrote: [...] +stored_height = (stored_height+15)/16*16; If this is supposed to match the actual macroblocks, then this would have to consider field pictures and interlacing as it di

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-14 Thread Michael Niedermayer
On Sat, Jan 14, 2023 at 04:48:10PM +0100, Jerome Martinez wrote: > Before the patch: > - stored values were rounded to upper 16 multiple also for formats not using > macroblocks (should be st->codecpar->width and st->codecpar->height when not > MPEG formats; note that I found no other muxer doing t

[FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-14 Thread Jerome Martinez
Before the patch: - stored values were rounded to upper 16 multiple also for formats not using macroblocks (should be st->codecpar->width and st->codecpar->height when not MPEG formats; note that I found no other muxer doing the rounding for AVC, only for MPEG-2 Video, but I find no reason in