Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-19 Thread Anton Khirnov
Quoting Carotti, Elias via ffmpeg-devel (2023-10-13 18:35:14) > I see. Wouldn't not outputting the SSE values when csp_to_pixfmt() > returns AV_PIX_FMT_NONE work better? > That wouldn't be worse than it is today (meaning that right now we > don't get those values for any pix_fmt). It would work

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-19 Thread Anton Khirnov
Quoting Carotti, Elias via ffmpeg-devel (2023-09-23 12:04:28) > Hi, > please find attached a patch to propagate the SSE for a frame into the > encoder stats. > Since libx264 already provides PSNR values, this is done by basically > inverting the formula to recover the SSE values. Thanks, pushed.

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-13 Thread Carotti, Elias via ffmpeg-devel
On Fri, 2023-10-13 at 16:16 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias via ffmpeg-devel (2023-10-11

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-13 Thread Anton Khirnov
Quoting Carotti, Elias via ffmpeg-devel (2023-10-11 12:54:21) > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index 77a9f173b4..85bd870f5d 100644 > --- a/libavcodec/libx264.c > +++ b/libavcodec/libx264.c > @@ -726,7 +726,39 @@ FF_ENABLE_DEPRECATION_WARNINGS > > pkt->flags |=

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-11 Thread Carotti, Elias via ffmpeg-devel
Hi Anton, On Tue, 2023-10-10 at 12:54 +0200, Anton Khirnov wrote: > > Quoting Carotti, Elias via ffmpeg-devel (2023-10-02 19:35:09) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > > index 77a9f173b4..4c643c9066 100644 > > --- a/libavcodec/libx264.c > > +++ b/libavcodec/libx264.c

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-10 Thread Anton Khirnov
Quoting Carotti, Elias via ffmpeg-devel (2023-10-02 19:35:09) > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index 77a9f173b4..4c643c9066 100644 > --- a/libavcodec/libx264.c > +++ b/libavcodec/libx264.c > @@ -129,6 +129,8 @@ typedef struct X264Context { > int roi_warned; > >

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-02 Thread Carotti, Elias via ffmpeg-devel
> Hi, > please find attached a patch to propagate the SSE for a frame into > the > encoder stats. > Since libx264 already provides PSNR values, this is done by basically > inverting the formula to recover the SSE values. > > Would it be possible to also append other values to the errors > vector?

[FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-09-23 Thread Carotti, Elias via ffmpeg-devel
Hi, please find attached a patch to propagate the SSE for a frame into the encoder stats. Since libx264 already provides PSNR values, this is done by basically inverting the formula to recover the SSE values. Would it be possible to also append other values to the errors vector? E.g., libx264