Ah, good spot Moritz. I found a few more spots where I wasn't consistent
with current formatting. Here are the updated patches.
Kind regards,
Dennis Fleurbaaij
On Tue, Jun 15, 2021 at 2:26 PM Moritz Barsnick wrote:
> On Wed, Jun 09, 2021 at 19:25:41 +0200, Dennis Fleurbaaij wrote:
> > OBJS-$(
On Wed, Jun 09, 2021 at 19:25:41 +0200, Dennis Fleurbaaij wrote:
> OBJS-$(CONFIG_R10K_ENCODER)+= r210enc.o
> OBJS-$(CONFIG_R210_DECODER)+= r210dec.o
> +OBJS-$(CONFIG_R12B_DECODER)+= r12bdec.o
> OBJS-$(CONFIG_R210_ENCODER)+= r210enc.o
I'm sure this
Patch 2/2 (patchwork seemt not handle both at the same time)
Kind regards,
Dennis Fleurbaaij
+31 (0) 6 54 21 5365
From 4f2b6a74863ff50906ba0fa1239914ab5618c304 Mon Sep 17 00:00:00 2001
From: Dennis Fleurbaaij
Date: Wed, 9 Jun 2021 19:21:14 +0200
Subject: [PATCH 2/2] libavformat: r12b decoder fou
By request of Carl Eugen here is the r12b decoder and the fourcc proposal
in 2 different patches so you can pick which ones are acceptable.
Kind regards,
Dennis Fleurbaaij
From 0d2243a6b566b17e7f669efb65f5398971964146 Mon Sep 17 00:00:00 2001
From: Dennis Fleurbaaij
Date: Wed, 9 Jun 2021 19:20:29
Am Di., 8. Juni 2021 um 11:52 Uhr schrieb Dennis Fleurbaaij
:
> The four letter "r12b" format code is from the DeckLink documentation;
> there are other described formats there as well such as r12l, r10b, r10l
> and r210. I'm using DirectShow which signals the encoding to downstream
> components t
Trying to get patchwork to pick up patch from thread.
Kind regards,
Dennis Fleurbaaij
From f66434cd65c5590c500e49eb6338aaa3a1c71a80 Mon Sep 17 00:00:00 2001
From: Dennis Fleurbaaij
Date: Tue, 8 Jun 2021 18:55:02 +0200
Subject: [PATCH] libavcodec: r12b decoder added
R12B is a format used by Black
Thanks again for the review Andreas. I've addressed the comments:
- moved back to the C90+ style which was in other decoders as well.
- The buffer size check makes sense and I've added that, I'm unsure
about how ffmpeg exactly handles alignment in some cases so I've opted to
stay on th
BTW, who knows how to show warnings on make job on patchwork? Only if make
fate fails you can see it, but not otherwise. Also, md5 warnings, when you
are going to fix those??
https://patchwork.ffmpeg.org/project/ffmpeg/patch/CAPUCmECSxQwMtttmRqTC-JtOpcfUB9SVQ8ZPZOHULFL9=2d...@mail.gmail.com/
_
Hi Carl,
Thanks for the question.
The four letter "r12b" format code is from the DeckLink documentation;
there are other described formats there as well such as r12l, r10b, r10l
and r210. I'm using DirectShow which signals the encoding to downstream
components through the use of FOURCC codes and
Von meinem iPhone gesendet
> Am 07.06.2021 um 12:09 schrieb Dennis Fleurbaaij :
>
> Pulled master and re-applied to resolve version update conflict
> R12B is a format used by BlackMagic DeckLink cards
How does the card produce avi files / why are you adding a fourcc?
Please elaborate, Carl
Dennis Fleurbaaij:
> Thanks for the review Andreas!
>
> I've addressed all your concerns besides the "& in the define", I didn't
> know that the binary AND is implicit in this situation, any link for this?
> Even if it is, I just find it much more pleasing to see the & there
> somehow, is there so
Thanks for the review Andreas!
I've addressed all your concerns besides the "& in the define", I didn't
know that the binary AND is implicit in this situation, any link for this?
Even if it is, I just find it much more pleasing to see the & there
somehow, is there some leniency for personal prefer
Dennis Fleurbaaij:
> Pulled master and re-applied to resolve version update conflict
>
> Kind regards,
> Dennis Fleurbaaij
>
>
>
> +if (avctx->width % PIXELS_PER_BLOCK != 0) {
> +av_log(avctx, AV_LOG_ERROR, "image width not modulo 8\n");
> +return AVERROR_INVALIDDATA;
> +
Pulled master and re-applied to resolve version update conflict
Kind regards,
Dennis Fleurbaaij
From b5fff34f545a107e07c9390a983e3a9aadb71a1c Mon Sep 17 00:00:00 2001
From: Dennis Fleurbaaij
Date: Mon, 7 Jun 2021 12:06:51 +0200
Subject: [PATCH] libavcodec: r12b decoder added
R12B is a format use
In my case
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210607063205.180031-1-val.zapod...@gmail.com/
v1 failed to apply due to
https://github.com/FFmpeg/FFmpeg/commit/575e52272d42f4278c6620f1a999c41425db2094
I suppose in your case it is
https://github.com/FFmpeg/FFmpeg/commit/8bcce5673a267
>From a distance, the patch looks like its in the correct format and
everything (generated by git format-patch, right?). Is it against
current HEAD? There may be a conflict
On Mon, Jun 7, 2021 at 8:02 AM Dennis Fleurbaaij
wrote:
>
> Failed to apply, what is the exact way you want the patch?
>
> K
Failed to apply, what is the exact way you want the patch?
Kind regards,
Dennis Fleurbaaij
+31 (0) 6 54 21 5365
On Sat, Jun 5, 2021 at 6:12 PM Valerii Zapodovnikov
wrote:
> That did work, cool.
>
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/capucmebbw-rkt3mw5berkg3cqa+-akryfahclfc36mh2
That did work, cool.
https://patchwork.ffmpeg.org/project/ffmpeg/patch/capucmebbw-rkt3mw5berkg3cqa+-akryfahclfc36mh2ybn...@mail.gmail.com/
BTW, will have to look into patchwork's patchwork (D:)) whether they fixed
.patch extensions. Apparently not. Also everything in "Re:" cannot contain
a patch.
Attempt nr three to get patchwork to see this patch; sorry for the spam.
From ed84960978fe87772c304402e204c5e37742d235 Mon Sep 17 00:00:00 2001
From: Dennis Fleurbaaij
Date: Sat, 5 Jun 2021 13:44:21 +0200
Subject: [PATCH] libavcodec: r12b decoder added
R12B is a format used by BlackMagic DeckLink
Nope, still is not seen. Try to send .txt in new thread. Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subjec
Alright thanks for the pointers. Attempt #2, hopefully this one will be
picked up.
Kind regards,
Dennis Fleurbaaij
+31 (0) 6 54 21 5365
On Fri, Jun 4, 2021 at 1:17 AM Valerii Zapodovnikov
wrote:
> You patch did not apply on patchwork and thus did not make fate tests.
> Please use .txt extensi
You patch did not apply on patchwork and thus did not make fate tests.
Please use .txt extension on the patch (BTW, what a joke) or use git
send-email. It is also very funny that gmail for android recognises patch
as video. Wht?
___
ffmpeg-devel maili
Hi ffmpeg-devel,
I've added a r12b decoder (12bpp RGB packing which packs 8 pixels into 36
bytes, used by Blackmagic Decklink cards). The patch is attached for your
consideration.
Kind regards,
Dennis Fleurbaaij
0001-libavcodec-r12b-decoder-added.patch
Description: Binary data
_
23 matches
Mail list logo
