Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-14 Thread Jonathan Campbell
> yes, please resbmit the remaining patch/changes with any comments > from everyone taken care of or with explanation why not > > thx Here you go, squashed into one patch. Sentences ending with a period have been capitalized and printf typecasts removed (Moritz). Jonathan Campbell From 8d640275

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-14 Thread Jonathan Campbell
>> Would running git format-patch >patchfile work to submit it as one patch or >> do I need to squash it into one patch? >> >> Do I need to resubmit anything? > > yes, please resbmit the remaining patch/changes with any comments > from everyone taken care of or with explanation why not > > thx >

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-13 Thread Michael Niedermayer
On Tue, Sep 13, 2016 at 10:08:06AM -0700, Jonathan Campbell wrote: > > > On 09/12/2016 07:58 PM, Michael Niedermayer wrote: > > On Mon, Sep 12, 2016 at 06:19:43PM -0700, Jonathan Campbell wrote: > >> > >> > >> On 09/12/2016 04:56 PM, Michael Niedermayer wrote: > >>> On Mon, Sep 12, 2016 at 03:28:

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-13 Thread Jonathan Campbell
On 09/13/2016 12:42 PM, Moritz Barsnick wrote: > On Mon, Sep 12, 2016 at 18:19:43 -0700, Jonathan Campbell wrote: >> Subject: [PATCH 2/7] read caption words field-wise, count properly and limit >> to cc_count. transfer each CC word taking into consideration immediate CC >> field bit or for DVDs

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-13 Thread Moritz Barsnick
On Mon, Sep 12, 2016 at 18:19:43 -0700, Jonathan Campbell wrote: > Subject: [PATCH 2/7] read caption words field-wise, count properly and limit > to cc_count. transfer each CC word taking into consideration immediate CC > field bit or for DVDs that don't use it, keep track according to first fiel

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-13 Thread Jonathan Campbell
On 09/12/2016 07:58 PM, Michael Niedermayer wrote: > On Mon, Sep 12, 2016 at 06:19:43PM -0700, Jonathan Campbell wrote: >> >> >> On 09/12/2016 04:56 PM, Michael Niedermayer wrote: >>> On Mon, Sep 12, 2016 at 03:28:24PM -0700, Jonathan Campbell wrote: These patches fix up the DVD caption hand

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-12 Thread Michael Niedermayer
On Mon, Sep 12, 2016 at 06:19:43PM -0700, Jonathan Campbell wrote: > > > On 09/12/2016 04:56 PM, Michael Niedermayer wrote: > > On Mon, Sep 12, 2016 at 03:28:24PM -0700, Jonathan Campbell wrote: > >> These patches fix up the DVD caption handling in mpeg12dec.c to better > >> handle odd cases. >

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-12 Thread Jonathan Campbell
On 09/12/2016 04:56 PM, Michael Niedermayer wrote: > On Mon, Sep 12, 2016 at 03:28:24PM -0700, Jonathan Campbell wrote: >> These patches fix up the DVD caption handling in mpeg12dec.c to better >> handle odd cases. >> It's based on code I've written elsewhere to handle captions. >> While it's co

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-12 Thread Michael Niedermayer
On Mon, Sep 12, 2016 at 03:28:24PM -0700, Jonathan Campbell wrote: > These patches fix up the DVD caption handling in mpeg12dec.c to better handle > odd cases. > It's based on code I've written elsewhere to handle captions. > While it's common for these packets to contain 15 frames worth and start

[FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-12 Thread Jonathan Campbell
These patches fix up the DVD caption handling in mpeg12dec.c to better handle odd cases. It's based on code I've written elsewhere to handle captions. While it's common for these packets to contain 15 frames worth and start on the odd field there are also DVDs that start on even field or even enc