Re: [FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Lou Logan
On Tue, Oct 15, 2019, at 3:06 PM, Mark Niebur wrote: > This should be fixed already on master? I checked a few hours ago and was > able to repro. Yes. Paul made the commit less than 10 minutes ago.

Re: [FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Mark Niebur
This should be fixed already on master? I checked a few hours ago and was able to repro. On Tue, Oct 15, 2019, 5:03 PM Paul B Mahol wrote: > Should be fixed. > > On 10/16/19, Mark Niebur wrote: > > I'm sorry for not specifying. In the case that data is not ready from > > ctx->inputs[1] after

Re: [FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Paul B Mahol
Should be fixed. On 10/16/19, Mark Niebur wrote: > I'm sorry for not specifying. In the case that data is not ready from > ctx->inputs[1] after crossfade is over, ff_inlink_consume_frame will return > 0 and not set the frame pointer. If ff_outlink_frame_wanted is still 0, the > function will

Re: [FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Mark Niebur
I'm sorry for not specifying. In the case that data is not ready from ctx->inputs[1] after crossfade is over, ff_inlink_consume_frame will return 0 and not set the frame pointer. If ff_outlink_frame_wanted is still 0, the function will fall through to the code filtering the frame, although

Re: [FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Paul B Mahol
On 10/15/19, Mark Niebur wrote: > I just checked out master and I see the fix you mentioned. This does not > completely fix acrossfade for me. I also had to apply the following patch: What this patch fixes? > diff --git a/libavfilter/af_afade.c b/libavfilter/af_afade.c > index

Re: [FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Mark Niebur
I just checked out master and I see the fix you mentioned. This does not completely fix acrossfade for me. I also had to apply the following patch: diff --git a/libavfilter/af_afade.c b/libavfilter/af_afade.c index 195fb65..446aa0a 100644 --- a/libavfilter/af_afade.c +++

Re: [FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Mark Niebur
Would this be on master or some other branch? > On Oct 15, 2019, at 2:26 PM, Paul B Mahol wrote: > > On 10/15/19, Mark Niebur wrote: >> Hello, >> I'm trying to debug an issue I'm seeing where the filter "acrossfade" >> produces a segfault. This seemingly only happens in docker containers, and

Re: [FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Paul B Mahol
On 10/15/19, Mark Niebur wrote: > Hello, > I'm trying to debug an issue I'm seeing where the filter "acrossfade" > produces a segfault. This seemingly only happens in docker containers, and > I am seeing it when running a rather large filter chain. I'm trying to get > to the bottom of it, but

[FFmpeg-devel] segfault in af_afade.c::activate

2019-10-15 Thread Mark Niebur
Hello, I'm trying to debug an issue I'm seeing where the filter "acrossfade" produces a segfault. This seemingly only happens in docker containers, and I am seeing it when running a rather large filter chain. I'm trying to get to the bottom of it, but it would be really helpful to understand