On 09.07.2017 19:42, Ashish Singh wrote:
Hi, added metadata scores and changed multipe string comparisons to few integer
comparisons.
---
Changelog| 1 +
doc/filters.texi | 20 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/ansnr.h
On 03.07.2017 18:01, Ashish Singh wrote:
Added ansnr section in doc/filters.texi and changelog and fixed issues.
---
Changelog| 1 +
doc/filters.texi | 24 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/ansnr.h | 29
lib
On Mon, Jul 03, 2017 at 18:39:38 +0530, Ashish Singh wrote:
> This is ANSNR filter, one of the component filters of VMAF.
Would you please expand the abbreviation in at least one place?
Optimally in doc/filters.texi, the content of which is missing (as it
still is in your VMAF patch). (And perhaps
Hi Betty,
On Mon, Apr 3, 2017 at 11:00 AM, Betty Wu wrote:
> +typedef double number_t;
>
Why?
+static int ansnr_filter(const uint8_t* src_image, number_t* dst_image, int
> img_row, int img_col, const double *filter, int stride)
>
[..]
> +number_t **imme_image;
> +if(!(imme_image = (nu
2017-04-03 23:00 GMT+08:00 Betty Wu :
> A new filter ANSNR is added. libavfilter/Makefile is changed.
> Run 'ffmpeg -i input1 -i input2 -lavfi ansnr -f null -' to get an overall
> score while per-frame value is stored but not printed.
> This implementation is for constructing the vmaf filter later
On Thu, Mar 30, 2017 at 23:06:36 +0200, Betty Wu wrote:
> A new filter ANSNR is added. libavfilter/Makefile is changed.
That line isn't really needed in a commit message (too obvious).
> +/*
> + * Copyright 2016-2017 Netflix, Inc.
> + * Copyright (c) 2017 Betty Wu
> + *
> + * This file is part of
2017-03-31 5:06 GMT+08:00 Betty Wu :
> A new filter ANSNR is added. libavfilter/Makefile is changed.
> Run 'ffmpeg -i input1 -i input2 -lavfi ansnr -f null -' to get an overall
> score while per-frame value is stored but not printed.
> This implementation is for constructing the vmaf filter later
On Thu, Mar 30, 2017 at 11:06:36PM +0200, Betty Wu wrote:
> A new filter ANSNR is added. libavfilter/Makefile is changed.
> Run 'ffmpeg -i input1 -i input2 -lavfi ansnr -f null -' to get an overall
> score while per-frame value is stored but not printed.
> This implementation is for constructing t
2017-03-30 22:44 GMT+08:00 Betty Wu :
> A new filter ANSNR is added. Makefile is changed.
> Run like 'ffmpeg -i input1 -i input2 -lavfi ansnr -f null -'.
> The implementation is for further constructing vmaf filter since ANSNR is
> one of individual tools used in vmaf.
>
> Signed-off-by: Betty Wu
