Re: [FFmpeg-devel] [PATCH] avutil/executor: Fix missing check before using mutex

2024-07-11 Thread Nuo Mi
On Mon, Jul 1, 2024 at 10:13 PM Nuo Mi wrote: > > > On Mon, Jul 1, 2024 at 10:00 PM Zhao Zhili wrote: > >> >> >> > On Jul 1, 2024, at 21:14, Nuo Mi wrote: >> > >> > On Sun, Jun 30, 2024 at 6:45 PM Zhao Zhili >> wrote: >> > >> >> From: Zhao Zhili >> >> >> >> --- >> >> The code can be simplifie

Re: [FFmpeg-devel] [PATCH] avutil/executor: Fix missing check before using mutex

2024-07-01 Thread Nuo Mi
On Mon, Jul 1, 2024 at 10:00 PM Zhao Zhili wrote: > > > > On Jul 1, 2024, at 21:14, Nuo Mi wrote: > > > > On Sun, Jun 30, 2024 at 6:45 PM Zhao Zhili > wrote: > > > >> From: Zhao Zhili > >> > >> --- > >> The code can be simplified by always creating mutex/cond. I'm not sure > >> it worth the ov

Re: [FFmpeg-devel] [PATCH] avutil/executor: Fix missing check before using mutex

2024-07-01 Thread Zhao Zhili
> On Jul 1, 2024, at 21:14, Nuo Mi wrote: > > On Sun, Jun 30, 2024 at 6:45 PM Zhao Zhili wrote: > >> From: Zhao Zhili >> >> --- >> The code can be simplified by always creating mutex/cond. I'm not sure >> it worth the overhead. Please note !HAVE_THREADS don't have the same >> problem since

Re: [FFmpeg-devel] [PATCH] avutil/executor: Fix missing check before using mutex

2024-07-01 Thread Nuo Mi
On Sun, Jun 30, 2024 at 6:45 PM Zhao Zhili wrote: > From: Zhao Zhili > > --- > The code can be simplified by always creating mutex/cond. I'm not sure > it worth the overhead. Please note !HAVE_THREADS don't have the same > problem since it has mock implementation of ff_mutex_lock/unlock. > Hi Zh