Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-04-06 Thread Anton Khirnov
Quoting David Bryant (2020-04-06 06:11:17) > On 4/2/20 11:32 PM, Anton Khirnov wrote: > > > >>> Also, I looked at the specification PDF you linked in the previous email > >>> and I see nothing in it that explicitly forbids the channel count from > >>> changing from one "superblock" to the next. It

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-04-05 Thread David Bryant
On 4/2/20 11:32 PM, Anton Khirnov wrote: > Quoting David Bryant (2020-04-03 07:14:21) >> On 4/2/20 2:13 AM, Anton Khirnov wrote: >>> Quoting David Bryant (2020-04-01 23:35:13) On 3/31/20 2:47 AM, Anton Khirnov wrote: >>> Looking at wavpack, the code looks suspicious to me. You allocate

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-04-03 Thread Anton Khirnov
Quoting David Bryant (2020-04-03 07:14:21) > On 4/2/20 2:13 AM, Anton Khirnov wrote: > > Quoting David Bryant (2020-04-01 23:35:13) > >> On 3/31/20 2:47 AM, Anton Khirnov wrote: > > Looking at wavpack, the code looks suspicious to me. You allocate one > > dsdctx per channel at init, but

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-04-02 Thread David Bryant
On 4/2/20 2:13 AM, Anton Khirnov wrote: > Quoting David Bryant (2020-04-01 23:35:13) >> On 3/31/20 2:47 AM, Anton Khirnov wrote: > Looking at wavpack, the code looks suspicious to me. You allocate one > dsdctx per channel at init, but AFAIU the number of channels can change > at each

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-04-02 Thread Anton Khirnov
Quoting David Bryant (2020-04-01 23:35:13) > On 3/31/20 2:47 AM, Anton Khirnov wrote: > >>> Looking at wavpack, the code looks suspicious to me. You allocate one > >>> dsdctx per channel at init, but AFAIU the number of channels can change > >>> at each frame. > >>> > >> Multichannel WavPack

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-04-01 Thread David Bryant
On 3/31/20 2:47 AM, Anton Khirnov wrote: > Quoting David Bryant (2020-03-28 21:22:40) >> On 3/28/20 6:23 AM, Anton Khirnov wrote: >>> Quoting David Bryant (2020-03-27 23:51:19) On 3/27/20 5:57 AM, Anton Khirnov wrote: > The current design, where > - proper init is called for the first

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-03-31 Thread Anton Khirnov
Quoting David Bryant (2020-03-28 21:22:40) > On 3/28/20 6:23 AM, Anton Khirnov wrote: > > Quoting David Bryant (2020-03-27 23:51:19) > >> On 3/27/20 5:57 AM, Anton Khirnov wrote: > >>> The current design, where > >>> - proper init is called for the first per-thread context > >>> - first thread's

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-03-28 Thread David Bryant
On 3/28/20 6:23 AM, Anton Khirnov wrote: > Quoting David Bryant (2020-03-27 23:51:19) >> On 3/27/20 5:57 AM, Anton Khirnov wrote: >>> The current design, where >>> - proper init is called for the first per-thread context >>> - first thread's private data is copied into private data for all the >>>

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-03-28 Thread Anton Khirnov
Quoting David Bryant (2020-03-27 23:51:19) > On 3/27/20 5:57 AM, Anton Khirnov wrote: > > The current design, where > > - proper init is called for the first per-thread context > > - first thread's private data is copied into private data for all the > > other threads > > - a "fixup" function is

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-03-27 Thread David Bryant
On 3/27/20 5:57 AM, Anton Khirnov wrote: > The current design, where > - proper init is called for the first per-thread context > - first thread's private data is copied into private data for all the > other threads > - a "fixup" function is called for all the other threads to e.g. > allocate