Re: [FFmpeg-devel] [PATCH v2 01/32] avfilter/palettegen: allow a minimum of 2 colors

2023-01-03 Thread Tomas Härdin
ons 2022-12-28 klockan 22:23 +0100 skrev Clément Bœsch: > On Wed, Dec 28, 2022 at 10:04:26PM +0100, Tomas Härdin wrote: > [...] > > Does this mean all-black with transparent is disallowed? > > Yes a single color with or without an extra transparency slot makes > no > sense. > > > Shouldn't it be

Re: [FFmpeg-devel] [PATCH v2 01/32] avfilter/palettegen: allow a minimum of 2 colors

2022-12-28 Thread Clément Bœsch
On Wed, Dec 28, 2022 at 10:04:26PM +0100, Tomas Härdin wrote: [...] > Does this mean all-black with transparent is disallowed? Yes a single color with or without an extra transparency slot makes no sense. > Shouldn't it be max_colors + reserve < 2? max_colors accounts for the transparent color a

Re: [FFmpeg-devel] [PATCH v2 01/32] avfilter/palettegen: allow a minimum of 2 colors

2022-12-28 Thread Tomas Härdin
ons 2022-12-28 klockan 00:17 +0100 skrev Clément Bœsch: > --- >  libavfilter/vf_palettegen.c | 7 ++- >  1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_palettegen.c > b/libavfilter/vf_palettegen.c > index 27f74fd147..c03f62b942 100644 > --- a/libavfilter/vf_palet