ought about making a similar comment. Lots of existing
users out there just know to add "-re" (and have it in scripts), and
the cost of keeping it as a simple alias to "readrate 1.0" is very
low.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1
Hi Anton,
Thanks for your feedback. Comments inline:
On Wed, May 3, 2023 at 5:20 AM Anton Khirnov wrote:
>
> Quoting Devin Heitmueller (2023-04-28 18:37:46)
> > +void ff_ccfifo_freep(AVCCFifo **ccf)
> > +{
> > +if (ccf && *ccf) {
>
> Don't ch
allocating the buffer beforehand and then having to
memcpy() the result into whatever memory it really needs to be in
(e.g. AVPacket side data).
Devin Heitmueller (6):
ccfifo: Properly handle CEA-708 captions through framerate conversion
vf_fps: properly preserve CEA-708 captions
yadif: Proper
rate.
Thanks for Lance Wang and Anton
Khirnov for providing review/feedback.
Signed-off-by: Devin Heitmueller
---
libavfilter/Makefile | 1 +
libavfilter/ccfifo.c | 222 +++
libavfilter/ccfifo.h | 110 +
3 files changed
1080i59 to 720p59 and
vice-versa).
Make use of the new ccfifo mechanism to ensure that caption data
is properly preserved.
Signed-off-by: Devin Heitmueller
---
libavfilter/vf_fps.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/libavfilter/vf_fps.c b/libavfilter
A-708 data is
properly preserved through this filter.
Signed-off-by: Devin Heitmueller
---
libavfilter/vf_bwdif.c | 8
libavfilter/vf_yadif.c | 8
libavfilter/vf_yadif_cuda.c | 9 +
libavfilter/yadif.h | 2 ++
libavfilter/yadif_common.c | 5 +
5
noticing a couple of
missed codepaths for injection on output. Thanks to Lance Wang
for pointing out a memory leak.
Signed-off-by: Devin Heitmueller
---
libavfilter/tinterlace.h| 2 ++
libavfilter/vf_tinterlace.c | 11 +++
2 files changed, 13 insertions(+)
diff --git a/libavfilter
ensuring the 608
tuples are at the front of the payload.
Signed-off-by: Devin Heitmueller
---
doc/filters.texi | 10 +
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_ccrepack.c | 102 ++
4 files changed
h used for log2_tab.c.
Signed-off-by: Devin Heitmueller
---
libavdevice/Makefile | 1 +
libavdevice/ccfifo.c | 24
libavdevice/decklink_common.h | 3 ++
libavdevice/decklink_enc.cpp | 65 +++
libavdevice/decklink_enc
to put
one of the checks back in because while it's safe to call
av_freep(*ccp) when it contains a NULL pointer it isn't safe to
dereference that pointer when freeing the associated FIFOs vis
av_fifo_freep2().
I'll include a fix in the next patch series.
Regards,
Devin
--
Devin
if (ret < 0) {
> > +av_frame_remove_side_data(frame, AV_FRAME_DATA_A53_CC);
> > +return AVERROR(ENOMEM);
> >
>
> prefer to return ret from ff_ccfifo_injectbytes()
Ok. I've got to regenerate patch #1 in the series anyway because of
the fate bug Michael repo
Updated series that includes the change requested by Lance Wang and
the fate test reported by Michael Niedermayer. Also includes a fix for
a 58-byte memory leak on uninitialization detected via valgrind while
debugging the fate issue.
Devin Heitmueller (6):
ccfifo: Properly handle CEA-708
rate.
Thanks to Lance Wang , Anton
Khirnov , and Michael Niedermayer
for providing review/feedback.
Signed-off-by: Devin Heitmueller
---
libavfilter/Makefile | 1 +
libavfilter/ccfifo.c | 224 +++
libavfilter/ccfifo.h | 110 +++
A-708 data is
properly preserved through this filter.
Signed-off-by: Devin Heitmueller
---
libavfilter/vf_bwdif.c | 8
libavfilter/vf_yadif.c | 8
libavfilter/vf_yadif_cuda.c | 9 +
libavfilter/yadif.h | 2 ++
libavfilter/yadif_common.c | 5 +
5
noticing a couple of
missed codepaths for injection on output. Thanks to Lance Wang
for pointing out a memory leak.
Signed-off-by: Devin Heitmueller
---
libavfilter/tinterlace.h| 2 ++
libavfilter/vf_tinterlace.c | 11 +++
2 files changed, 13 insertions(+)
diff --git a/libavfilter
h used for log2_tab.c.
Signed-off-by: Devin Heitmueller
---
libavdevice/Makefile | 1 +
libavdevice/ccfifo.c | 24
libavdevice/decklink_common.h | 3 ++
libavdevice/decklink_enc.cpp | 65 +++
libavdevice/decklink_enc
ensuring the 608
tuples are at the front of the payload.
Signed-off-by: Devin Heitmueller
---
doc/filters.texi | 10 +
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_ccrepack.c | 102 ++
4 files changed
1080i59 to 720p59 and
vice-versa).
Make use of the new ccfifo mechanism to ensure that caption data
is properly preserved.
Signed-off-by: Devin Heitmueller
---
libavfilter/vf_fps.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/libavfilter/vf_fps.c b/libavfilter
/ffmpeg -f bitpacked -pix_fmt yuv422p10le -s 3840x2160 -c:v bitpacked -i
source.yuv -pix_fmt yuv422p10le out.yuv
On my development system, it went from 80ms for a 2160p frame
down to 20ms (i.e. a 4X speedup). Good enough for now, I hope...
Signed-off-by: Devin Heitmueller
---
libavcodec/bitpacked_
to gettimeofday() in libavcodec/bitpacked_dec.c before
and after the decoding operation.
This is one of those cases where you won't notice the performance
difference doing any operation once, but it becomes important when
you're processing a live RTP stream of 2160p59 video at 10.4 Gbps
box is only 2.5x
rather than 4x.
Devin
On Sat, May 6, 2023 at 7:53 AM Paul B Mahol wrote:
>
> On Sat, May 6, 2023 at 1:32 PM Lance Wang wrote:
>
> > On Sat, May 6, 2023 at 4:58 AM Devin Heitmueller <
> > devin.heitmuel...@ltnglobal.com> wrote:
> >
> > >
1 runs, 0 skips
252701500 decicycles in bitpacked_dec, 1 runs, 0 skips
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com
timing3.patch
Description:
Hi Marton,
On Fri, Apr 28, 2023 at 1:45 PM Devin Heitmueller
wrote:
>
> This patch series implements output of SMPTE 2038 VANC over SDI, building
> on the prior patch series which added it in the TS domain. Note that
> we moved the AVPacketQueue to be common code within libavdevice
ATE
without complaint.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mail
Address build breakage caused by my latest series when compiling
with CUDA support. Thanks to Paul Mahol for pointing it out.
Signed-off-by: Devin Heitmueller
---
libavfilter/vf_yadif_cuda.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/vf_yadif_cuda.c b
for patch 3. I will need a bit more time to
> think about patch 4. :)
Sounds good.
Thanks
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmuel...@l
dback from Marton Balint provided on 05/11/23.
Signed-off-by: Devin Heitmueller
---
libavdevice/decklink_common.cpp | 50 +
1 file changed, 15 insertions(+), 35 deletions(-)
diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp
ind
or such things.
I will point out though that the patch doesn't include the usage in
libavdevice/decklink_enc.cpp, so it would cause build breakage if the
proposed changes are not reflected in that file as well.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o
ome feedback from others.
Looking at the code to libavcodec/git_bits.h, it might also be worth
looking at setting #define LONG_BITSTREAM_READER, as that might speed
things up as well for such large files.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
since I'm not the one who is
doing that work it wouldn't be appropriate for me to say, "it's worth
it". But as a user of the libraries I will say it would indeed be
very nice if I could have out-of-tree filters.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Glo
301 - 330 of 330 matches
Mail list logo
