Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-12 Thread James Zern
On Fri, Jan 8, 2021 at 3:33 PM Wonkap Jang wrote: > > In order to fine-control referencing schemes in VP9 encoding, there > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > provides a way to use the API through frame metadata. > --- > doc/encoders.texi | 32 ++

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-14 Thread James Zern
On Tue, Jan 12, 2021 at 3:28 PM James Zern wrote: > > On Fri, Jan 8, 2021 at 3:33 PM Wonkap Jang > wrote: > > > > In order to fine-control referencing schemes in VP9 encoding, there > > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > > prov

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxdec: Remove redundant unreferencing of AVFrame

2023-09-18 Thread James Zern via ffmpeg-devel
On Mon, Sep 18, 2023 at 5:40 AM Andreas Rheinhardt wrote: > > The AVFrame of a decoder with the ordinary decode callback > is generically unreferenced on error. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxdec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > lgtm

Re: [FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-02-07 Thread James Zern via ffmpeg-devel
Hi, On Wed, Feb 7, 2024 at 8:04 AM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > For the subject use '(libavcodec|avcodec|lavc)/libvpxenc: ...' to better document what is being changed. See the history of the file for examples.

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpxenc: add screen-content-mode option

2024-02-09 Thread James Zern via ffmpeg-devel
On Thu, Feb 8, 2024 at 1:58 PM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx and makes > us retry encode if screen_content_mode == 2 and no output was produced > by encoder. > > Co-authored-by: Erik Språng > Signed-off-by: Dariusz M

Re: [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled

2024-04-01 Thread James Zern via ffmpeg-devel
On Sat, Mar 30, 2024 at 10:30 PM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxenc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 635cdf7a0e..bcbdc4981e 100644 >

Re: [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled

2024-04-02 Thread James Zern via ffmpeg-devel
On Mon, Apr 1, 2024 at 11:29 AM Andreas Rheinhardt wrote: > > James Zern via ffmpeg-devel: > > On Sat, Mar 30, 2024 at 10:30 PM Andreas Rheinhardt > > wrote: > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/libvpxenc.

Re: [FFmpeg-devel] [PATCH v11 4/8] libavcodec/webp: add support for animated WebP

2024-04-17 Thread James Zern via ffmpeg-devel
On Thu, Mar 28, 2024 at 7:10 AM Thilo Borgmann via ffmpeg-devel wrote: > > From: Josef Zlomek > > Fixes: 4907 > > Adds support for decoding of animated WebP. > > The WebP decoder adds the animation related features according to the specs: > https://developers.google.com/speed/webp/docs/riff_conta

Re: [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding

2024-04-17 Thread James Zern via ffmpeg-devel
On Wed, Apr 17, 2024 at 12:20 PM Thilo Borgmann via ffmpeg-devel wrote: > > From: Thilo Borgmann > > Marked WIP because we'd want to introduce private bsf's first; review > welcome before that though > VP8 decoder decoupled again > The whole animated sequence goes into one packet > The (currently

Re: [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding

2024-04-18 Thread James Zern via ffmpeg-devel
On Thu, Apr 18, 2024 at 11:21 AM Thilo Borgmann via ffmpeg-devel wrote: > > Hi, > > On 17.04.24 00:52, James Zern via ffmpeg-devel wrote: > > On Wed, Apr 17, 2024 at 12:20 PM Thilo Borgmann via ffmpeg-devel > > wrote: > >> > >> From: Thilo Borgmann

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: Fix parsing of ts_layering_mode parameter

2024-05-17 Thread James Zern via ffmpeg-devel
Hi, On Wed, May 15, 2024 at 11:11 PM Aaron Thompson via ffmpeg-devel wrote: > > The value was being parsed as base 4, so the value "4" was invalid and > would result in ts_layering_mode being set to 0. > > Signed-off-by: Aaron Thompson > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding

2024-05-22 Thread James Zern via ffmpeg-devel
On Tue, May 21, 2024 at 9:50 AM Thilo Borgmann via ffmpeg-devel wrote: > > Hi, > > [...] > >>> Tests mostly work for me. There are a few images (that I reported > >>> earlier) that give: > >> > >> thanks for testing! > >> > >> > >>> Canvas change detected. The output will be damaged. Use -thre

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error

2024-06-17 Thread James Zern via ffmpeg-devel
On Sun, Jun 16, 2024 at 4:09 PM Michael Niedermayer wrote: > > This or fifo needs to be freed on errors explicitly > I have not verified that its always safe to call vpx_free() this needs to be > checked before applying this > It should be safe to call into libvpx whether the encoder init succee

Re: [FFmpeg-devel] [PATCH v4] lavc/libvpxenc: add screen-content-mode option

2024-02-12 Thread James Zern via ffmpeg-devel
On Sat, Feb 10, 2024 at 12:22 AM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > Co-authored-by: Erik Språng > Signed-off-by: Dariusz Marcinkiewicz > --- > doc/encoders.texi | 3 +++ > libavcodec/libvpxenc.c | 11

Re: [FFmpeg-devel] [PATCH v5] lavc/libvpxenc: add screen-content-mode option

2024-02-13 Thread James Zern via ffmpeg-devel
On Mon, Feb 12, 2024 at 10:34 PM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > Co-authored-by: Erik Språng > Signed-off-by: Dariusz Marcinkiewicz > --- > doc/encoders.texi | 6 ++ > libavcodec/libvpxenc.c | 13 +

Re: [FFmpeg-devel] [PATCH v5] lavc/libvpxenc: add screen-content-mode option

2024-02-15 Thread James Zern via ffmpeg-devel
On Tue, Feb 13, 2024 at 7:26 PM James Zern wrote: > > On Mon, Feb 12, 2024 at 10:34 PM Dariusz Marcinkiewicz via > ffmpeg-devel wrote: > > > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > > > Co-authored-by: Erik Språng > &g

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/libvpxenc: Only search for side data when intending to use it

2024-03-27 Thread James Zern via ffmpeg-devel
On Tue, Mar 26, 2024 at 6:36 PM Andreas Rheinhardt wrote: > > Also rewrite the code so that a variable that is only used > depending upon CONFIG_LIBVPX_VP9_ENCODER is not declared > outside of the #if block. > (The variable was declared with av_uninit, but it should have been > av_unused, as the f

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/libvpxenc: Remove obsolete av_unused

2024-03-27 Thread James Zern via ffmpeg-devel
On Tue, Mar 26, 2024 at 6:38 PM Andreas Rheinhardt wrote: > > Forgotten in 753074721bd414874d18c372c491bdc6323fa3bf. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm. _

Re: [FFmpeg-devel] [PATCH 03/10] MAINTAINERS: Add W field based on the linux kernel MAINTAINERs

2024-08-28 Thread James Zern via ffmpeg-devel
On Wed, Aug 28, 2024 at 10:13 AM Michael Niedermayer wrote: > > Text was stolen from the linux kernel > This is thus identical to the kernel just a different more compact format. > I am very happy also to switch the file entirely to the format of the linux > kernel maintainer list > if people pre

Re: [FFmpeg-devel] [PATCH v4 06/17] avcodec/libvpxenc: switch to get_supported_config()

2024-09-05 Thread James Zern via ffmpeg-devel
On Wed, Sep 4, 2024 at 4:10 AM Niklas Haas wrote: > > From: Niklas Haas > > --- > libavcodec/libvpxenc.c | 26 +++--- > 1 file changed, 19 insertions(+), 7 deletions(-) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

<    1   2   3   4   5