Re: [FFmpeg-devel] [PATCH v2] configure: fix symbol prefix detection

On Wed, 11 Sep 2024, Marvin Scholz wrote: The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong.

Re: [FFmpeg-devel] [PATCH] tests/checkasm/sw_rgb: don't write random data past the end of the buffer

On Thu, 12 Sep 2024, Ramiro Polla wrote: On Thu, Sep 12, 2024 at 8:44 AM James Almer wrote: Should fix fate-checkasm-sw_rgb under gcc-ubsan. Signed-off-by: James Almer --- tests/checkasm/sw_rgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/sw_rgb.c b/

Re: [FFmpeg-devel] Procedure to enable the Windows on ARM64 FFMPEG Libraries

On Thu, 12 Sep 2024, Niranjan Kshatriya (QUIC) wrote: and compiled locally ( on ARM using WSL ) for Arm with tool chain : GitHub - Windows-on-ARM-Experiments/mingw-woarm64-build: Workflows and build scripts for Windows on Arm64 GNU cross-compiler for `aarch64-w64-mingw32` target.

Re: [FFmpeg-devel] [PATCH v2 00/14] aarch64/vvc: Add SIMD

On Thu, 12 Sep 2024, Zhao Zhili wrote: From: Zhao Zhili Patches 1~9 has been updated according to Martin's review. Patches 10~14 are new. I have created a PR on github: https://github.com/quink-black/FFmpeg/pull/2 Thanks for testing it through that set of tests! No further comments from m

Re: [FFmpeg-devel] [PATCH v3 2/2] configure: correctly set sanitizer toolchain compilers

On Thu, 12 Sep 2024, Marvin Scholz wrote: Previously only the C compiler was set, which would lead to confusing situations where even though clang-asan was selected, it would still use g++ for C++ code, failing because configure does not support mixing compilers in this way (which is a separate

Re: [FFmpeg-devel] [PATCH] configure: Remove a leftover comment about MSVC C99 support

On Wed, 19 Oct 2022, Martin Storsjö wrote: Support for building with older versions of MSVC (with the c99wrap/c99conv frontend) was removed in ce943dd6acbfdfc40223c0fb24d4cad438e6499c. Signed-off-by: Martin Storsjö --- configure | 6 -- 1 file changed, 6 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH] swscale: aarch64: Fix yuv2rgb with negative strides

On Tue, 25 Oct 2022, Martin Storsjö wrote: Treat the 32 bit stride registers as signed. Alternatively, we could make the stride arguments ptrdiff_t instead of int, and changing all of the assembly to operate on these registers with their full 64 bit width, but that's a much larger and

Re: [FFmpeg-devel] [PATCH 0/3] sw_scale: Provide neon implementation for hscale

On Fri, 28 Oct 2022, Hubert Mazur wrote: This patchset contains arm64 neon implementation of hscale functions. Fixed minor style issues and declared C function wrappers as static. This patchset do not contain the patch for checkasm tool, as the previous one did. The reason behind it was failing

Re: [FFmpeg-devel] [PATCH 2/2] swscale/output: Bias 16bps output calculations to improve non overflowing range for GBRP16/GBRPF32

On Wed, 2 Nov 2022, Michael Niedermayer wrote: On Wed, Nov 02, 2022 at 10:16:57PM +0100, Andreas Rheinhardt wrote: Michael Niedermayer: On Wed, Nov 02, 2022 at 10:02:39PM +0100, Michael Niedermayer wrote: Fixes: integer overflow Signed-off-by: Michael Niedermayer --- libswscale/output.c

Re: [FFmpeg-devel] [PATCH] avutil/tx: use llrintf() to convert a float into a 64 bit integer

On Tue, 8 Nov 2022, James Almer wrote: Should fix fate failures on Windowx x86 targets, where long is 32 bits. Signed-off-by: James Almer --- libavutil/tx_priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/tx_priv.h b/libavutil/tx_priv.h index 3195cb51b2..fb611

[FFmpeg-devel] [PATCH] fate: Mark the tiff-zip-* tests as requiring zlib

Signed-off-by: Martin Storsjö --- tests/fate/image.mak | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 167c8ccf2c..42dd90feaa 100644 --- a/tests/fate/image.mak +++ b/tests/fate/image.mak @@ -513,12 +513,13 @@ fate-tiff

Re: [FFmpeg-devel] [PATCH] fate: Mark the tiff-zip-* tests as requiring zlib

On Thu, 17 Nov 2022, Martin Storsjö wrote: Signed-off-by: Martin Storsjö --- tests/fate/image.mak | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 167c8ccf2c..42dd90feaa 100644 --- a/tests/fate/image.mak +++ b/tests/fate

Re: [FFmpeg-devel] [PATCH] arm32/neon: Avoid using bge/beq for function calls

Hi Rui, Long time no see! On Sat, 7 Jan 2023, Rui Ueyama wrote: It looks like compiler-generated code always uses `b`, `bl` or `blx` instructions for function calls. These instructions have a 24-bit immediate and therefore can jump anywhere between PC +- 16 MiB. This hand-written assembly cod

Re: [FFmpeg-devel] [PATCH] arm32/neon: Avoid using bge/beq for function calls

On Mon, 9 Jan 2023, Martin Storsjö wrote: Hi Rui, Long time no see! On Sat, 7 Jan 2023, Rui Ueyama wrote: It looks like compiler-generated code always uses `b`, `bl` or `blx` instructions for function calls. These instructions have a 24-bit immediate and therefore can jump anywhere between

Re: [FFmpeg-devel] [PATCH] arm32/neon: Avoid using bge/beq for function calls

Hi Rui, On Sat, 14 Jan 2023, Rui Ueyama wrote: On Sat, 7 Jan 2023, Rui Ueyama wrote: It looks like compiler-generated code always uses `b`, `bl` or `blx` instructions for function calls. These instructions have a 24-bit immediate and therefore can jump anywhere between PC +- 16 MiB. This han

[FFmpeg-devel] [PATCH] lavu/video_enc_params: Avoid relying on an undefined C construct

. [1] https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2350.htm [2] https://github.com/llvm/llvm-project/commit/e327b52766ed497e4779f4e652b9ad237dfda8e6 [3] https://reviews.llvm.org/D133574#4053647 Signed-off-by: Martin Storsjö --- libavutil/video_enc_params.c | 10 +- 1 file chang

[FFmpeg-devel] [PATCH] mov: Reduce the verbosity of the warning about fragmented MP4 vs advanced edit lists

Only warn if the advanced_editlist option is enabled (it is enabled by default though) so we don't print one warning for each track, and demote the warning to AV_LOG_LEVEL_VERBOSE; this message does get generated whenever parsing a fragmented MP4 file, regardless of whether the file actually uses m

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: fix double-free on init failure

On Fri, 20 Jan 2023, Cameron Gutman wrote: mfenc sets FF_CODEC_CAP_INIT_CLEANUP, so calling mf_close() on failure inside mf_init() results in a double-free. Signed-off-by: Cameron Gutman --- libavcodec/mfenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mfenc.c b/libavcodec/mf

Re: [FFmpeg-devel] [PATCH v2] avformat/rtspdec: fix potential mem leak in listen mode

On Thu, 26 Nov 2020, Andriy Gelman wrote: From: Andriy Gelman Currently a repeating setup request (with the same stream id) will simply overwrite rtp_handle/transport_priv without freeing the resources first. This is fixed by closing the previous setup request. Signed-off-by: Andriy Gelman -

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtspdec: show method request in log

On Thu, 26 Nov 2020, Andriy Gelman wrote: From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 28b35d1993..be11576913 100644 --- a/libavformat/rtspdec.c +++ b/libavfo

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

On Fri, 11 Dec 2020, Josh Allmann wrote: A negative start_dts value (eg, delay from edit lists) typically yields a duration larger than end_pts. During edit list processing, the delay is removed again, yielding the correct duration within the elst. However, other duration-carrying atoms (tkhd,

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

Hi, On Fri, 11 Dec 2020, Josh Allmann wrote: On Fri, 11 Dec 2020 at 14:07, Martin Storsjö wrote: On Fri, 11 Dec 2020, Josh Allmann wrote: > A negative start_dts value (eg, delay from edit lists) typically yields > a duration larger than end_pts. During edit list processing, the >

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

On Fri, 11 Dec 2020, Josh Allmann wrote: On Fri, 11 Dec 2020 at 14:07, Martin Storsjö wrote: On Fri, 11 Dec 2020, Josh Allmann wrote: > A negative start_dts value (eg, delay from edit lists) typically yields > a duration larger than end_pts. During edit list processing, the >

[FFmpeg-devel] [PATCH] movenc: Present durations in mvhd/tkhd/mdhd as they are after edits

If the edit lists remove parts of the output timeline, or add a delay to it, this should be included in the mvhd/tkhd/mdhd durations, which should correspond to the edit lists. For tracks starting with pts < 0, the edit list trims out the segment before pts=0. For tracks starting with pts > 0, a d

Re: [FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

Hi, On Tue, 12 Jan 2021, Reimar Döffinger wrote: I’m not sure it will discourage it more than having to write the optimizations over and over, for Armv7 NEON, for Armv8 Linux, for Armv8 Windows, then SVE/SVE2, who knows maybe Armv9 will also need a rewrite. NEON code for armv8 windows and arm

Re: [FFmpeg-devel] [PATCH] libavcodec/hevcdsp: port SIMD idct functions from 32-bit.

On Tue, 12 Jan 2021, Reimar Döffinger wrote: On 12 Jan 2021, at 13:24, Josh Dekker wrote: Hi, AS libavcodec/aarch64/hevcdsp_idct_neon.o libavcodec/aarch64/hevcdsp_idct_neon.S: Assembler messages: libavcodec/aarch64/hevcdsp_idct_neon.S:418: Error: operand mismatch -- `mov v29.4S,v28.4S'

Re: [FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

On Wed, 13 Jan 2021, Reimar Döffinger wrote: If building with MSVC tools, yes you're right that armasm.exe/armasm64.exe takes a different syntax. But the gas-preprocessor tool (which is picked up automatically by our configure, one just needs to make sure it's available) handles expanding all

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

Hi Josh, On Tue, 22 Dec 2020, Josh Allmann wrote: Thank you for taking the time to look into this! Tested with your alternative patch and it does seem to be an improvement. I was able to find a case where it didn't seem to do the correct thing (described below), but this is not a regression; ma

Re: [FFmpeg-devel] [PATCH] libswscale/aarch64/hscale.S: Support more bit-depth variants.

On Mon, 11 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger Trivially expand hscale assembler to support > 8 bit formats both for input and output. 16-bit input is not supported as I am not certain how to get sufficient test coverage. --- libswscale/aarch64/hscale.S | 53 +

Re: [FFmpeg-devel] [PATCH] configure: Set MSVC as_default later.

On Fri, 15 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger It would get immediately overridden to $cc, which in case of gas-preprocessor missing would result in it trying to use cl.exe for asm files instead of erroring out. This is because cl.exe does not fail but just print a

Re: [FFmpeg-devel] [PATCH] libavcodec/hevcdsp: port SIMD idct functions from 32-bit.

On Tue, 12 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger Makes SIMD-optimized 8x8 and 16x16 idcts for 8 and 10 bit depth available on aarch64. For a UHD HDR (10 bit) sample video these were consuming the most time and this optimization reduced overall decode time from 19.4s

Re: [FFmpeg-devel] [PATCH] libavcodec/aarch64/hevcdsp_idct_neon.S: Also port add_residual functions.

On Sun, 10 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger Speedup is fairly small, around 1.5%, but these are fairly simple. --- libavcodec/aarch64/hevcdsp_idct_neon.S| 190 ++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 24 +++ 2 files changed, 214 ins

Re: [FFmpeg-devel] [PATCH] configure: Set MSVC as_default later.

On Sat, 16 Jan 2021, Reimar Döffinger wrote: On 15 Jan 2021, at 23:25, Martin Storsjö wrote: On Fri, 15 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger It would get immediately overridden to $cc, which in case of gas-preprocessor missing would result in it trying to

Re: [FFmpeg-devel] [PATCH] libavcodec/hevcdsp: port SIMD idct functions from 32-bit.

On Sat, 16 Jan 2021, Reimar Döffinger wrote: On 15 Jan 2021, at 23:55, Martin Storsjö wrote: On Tue, 12 Jan 2021, reimar.doeffin...@gmx.de wrote: create mode 100644 libavcodec/aarch64/hevcdsp_idct_neon.S create mode 100644 libavcodec/aarch64/hevcdsp_init_aarch64.c This patch fails

Re: [FFmpeg-devel] [PATCH 1/4] lavc/aarch64: add HEVC add_residual NEON

On Thu, 7 Jan 2021, Josh Dekker wrote: Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/hevcdsp_add_res_neon.S | 298 ++ libavcodec/aarch64/hevcdsp_init.c | 59 + libavcodec/hevcdsp.c | 2 +

Re: [FFmpeg-devel] [PATCH 2/4] lavc/aarch64: add HEVC idct_dc NEON

On Thu, 7 Jan 2021, Josh Dekker wrote: Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile| 3 +- libavcodec/aarch64/hevcdsp_idct_neon.S | 74 ++ libavcodec/aarch64/hevcdsp_init.c | 19 +++ 3 files changed, 95 insertions(+), 1 deletion(-) create

Re: [FFmpeg-devel] [PATCH 3/4] lavc/aarch64: add HEVC sao_band NEON

On Thu, 7 Jan 2021, Josh Dekker wrote: Only works for 8x8. Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile | 3 +- libavcodec/aarch64/hevcdsp_init.c | 7 +++ libavcodec/aarch64/hevcdsp_sao_neon.S | 87 +++ 3 files changed, 96 insertions(+), 1 del

[FFmpeg-devel] [GASPP PATCH 1/2] Recognize aarch64 register ranges with .16b suffixes too

Match e.g. "ld1 {v16.16b-v19.16b}". Previously this regex only matched lane specifiers with a single digit, e.g. "ld1 {v16.8h-v19.8h}". --- gas-preprocessor.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index c4b1c1d..4d78dac 1007

[FFmpeg-devel] [GASPP PATCH 2/2] Match aarch64 register lists with tbl/tbx too

Remove the restriction on matching on the same line as ld1/st1 and similar ones; the pattern for the register list itself should be strict enough to avoid false matches. --- gas-preprocessor.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocess

Re: [FFmpeg-devel] [GASPP PATCH 2/2] Match aarch64 register lists with tbl/tbx too

On Sun, 17 Jan 2021, Martin Storsjö wrote: Remove the restriction on matching on the same line as ld1/st1 and similar ones; the pattern for the register list itself should be strict enough to avoid false matches. --- gas-preprocessor.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] configure: add fallback to $arch in msvc assembler check.

On Sat, 23 Jan 2021, Reimar Döffinger wrote: Setting the defaults for $arch happens only later, so the current code would not set AS correctly if --arch was not specified on the command-line. Fix it by adding an explicit fallback to $arch_default. --- configure | 2 +- 1 file changed, 1 insertion

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

On Sun, 3 Jan 2016, Derek Buitenhuis wrote: It serves absolutely no purpose other than to confuse potentional Android developers about how to use hardware acceleration properly on the the platform. Both stagefright itself, and MediaCodec, have avcodec backends already, and this is the correct wa

Re: [FFmpeg-devel] [PATCH] configure: reenable tree vectorization for GCC

On Fri, 3 Jul 2020, James Almer wrote: On 7/3/2020 9:00 AM, Lynne wrote: Maybe they've fixed the FATE failures. We have done this at least two times before, and all of them limited to the newest compilers which supposedly were good. It always resulted in compilations issues being reported soo

Re: [FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

On Sun, 5 Jul 2020, Hongcheng Zhong wrote: From: spartazhc Add abr module for hls/dash. Signed-off-by: spartazhc --- doc/protocols.texi | 7 + libavformat/Makefile| 1 + libavformat/abr.c | 282 libavformat/protocols.c | 1 + 4 files

Re: [FFmpeg-devel] [PATCH] yuv2rgb_neon: fix return value

On Tue, 7 Jul 2020, Lynne wrote: We return 0 for this particular architecture but should instead be returning the number of lines. Fixes users who check the return value matches what they expect. The change looks good in itself, but it also looks like we have the same issue in the arm version

Re: [FFmpeg-devel] [PATCH] swscale/tests: check return value of sws_scale

On Tue, 7 Jul 2020, Lynne wrote: Patch attached. From a89bfd810cf40e3005fbcbdcf43a7b858b4dd12c Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 7 Jul 2020 22:19:14 +0100 Subject: [PATCH] swscale/tests: check return value of sws_scale --- libswscale/tests/swscale.c | 4 +++- 1 file changed,

Re: [FFmpeg-devel] [PATCH 1/2] swscale/tests/swscale: Fix incorrect return code check

On Sun, 12 Jul 2020, Michael Niedermayer wrote: Regression since: 3adffab073bc59af39035168ac72bc9ffde3 Signed-off-by: Michael Niedermayer --- libswscale/tests/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.

Re: [FFmpeg-devel] [PATCH 2/2] swscale/tests/swscale: Initialize res to a non random error code

On Sun, 12 Jul 2020, Michael Niedermayer wrote: Regression since: 3adffab073bc59af39035168ac72bc9ffde3 -1 is consistent what other error paths return Signed-off-by: Michael Niedermayer --- libswscale/tests/swscale.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib

Re: [FFmpeg-devel] [PATCH 2/2] swscale/tests/swscale: use codes < 128 for indicating erros

On Thu, 16 Jul 2020, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libswscale/tests/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c index 845ced61bb..9c0b5a4b11 100644 --- a/libswscale/tests

Re: [FFmpeg-devel] working with file descriptors on Android

Hi, Without having too much opinion on the JNI stuff (direct access to content:// urls might be convenient, but on the other hand, it's not really something you'd end up with if using the command line tool on its own - if you have one of those you most probably have some java code for getting

[FFmpeg-devel] [PATCH 3/3] test: hlsenc: Use unique init/segment file names for the fmp4_ac3 test

Previously, the hls-fmp4 and hls-fmp4_ac3 tests used the same file names for init and segment files, which occasionally could cause corruption and failed tests, if the input files for both tests are generated in parallel, as they could overwrite each other. This happened to work some of the time,

[FFmpeg-devel] [PATCH 2/3] test: hlsenc: Make fate-hls-fmp4 actually use the right segment type

Since this test was added in ac22835db947e, it actually has been using segment type mpegts, contrary to what the test looks like it is supposed to test. --- tests/fate/hlsenc.mak | 2 +- tests/ref/fate/hls-fmp4 | 384 2 files changed, 193 insertions(+),

[FFmpeg-devel] [PATCH 1/3] test: hlsenc: Make the hls_fmp4 sample file name match the target

Previously, with the file name not matching the target, the files were regenerated every time fate is rerun - contrary to the other test targets in the same file. (While regenerating it every time might be desireable, as that's what the test is about, the file at least has a dependency on the ffmpe

Re: [FFmpeg-devel] [PATCH 3/3] test: hlsenc: Use unique init/segment file names for the fmp4_ac3 test

On Sunday, August 2, 2020, Andreas Rheinhardt wrote: > Martin Storsjö: > > Previously, the hls-fmp4 and hls-fmp4_ac3 tests used the same file > > names for init and segment files, which occasionally could cause > > corruption and failed tests, if the input files for both te

Re: [FFmpeg-devel] [PATCH 2/3] test: hlsenc: Make fate-hls-fmp4 actually use the right segment type

On Sun, 2 Aug 2020, Steven Liu wrote: Martin Storsjö 于2020年8月2日周日 下午2:49写道： Since this test was added in ac22835db947e, it actually has been using segment type mpegts, contrary to what the test looks like it is supposed to test. --- tests/fate/hlsenc.mak | 2 +- tests/ref/fate/hls-fmp4

[FFmpeg-devel] [PATCH 2/2] test: hlsenc: Fix the dependencies of the tests

Most tests here don't depend on samples, thus add them to FATE_FFMPEG instead of FATE_SAMPLES_FFMPEG. The fate-hls-fmp4_ac3 test depends on both samples and ffprobe; add that one separately to FATE_SAMPLES_FFMPEG_FFPROBE instead. --- tests/fate/hlsenc.mak | 7 --- 1 file changed, 4 insertions

[FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

This parameter artificially throttled the generation of the test sample to take 5 seconds. --- tests/fate/hlsenc.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak index dce1f377c7..3c767fd5d9 100644 --- a/tests/fate/hlsenc.mak +++

[FFmpeg-devel] [PATCH] fate: Update the test references for h264-skip-nokey and h264-skip-noparse after b48397e7b84864f2

--- tests/ref/fate/h264-skip-nointra | 86 tests/ref/fate/h264-skip-nokey | 86 2 files changed, 86 insertions(+), 86 deletions(-) diff --git a/tests/ref/fate/h264-skip-nointra b/tests/ref/fate/h264-skip-nointra index 0259902927.

Re: [FFmpeg-devel] [FFmpeg-cvslog] mpegaudiodec_template: disable CRC checking for layers 1 and 2

On Sun, 2 Aug 2020, Lynne wrote: ffmpeg | branch: master | Lynne | Sun Aug 2 22:45:00 2020 +0200| [b48397e7b84864f2d4c70361a4c4bed93e826753] | committer: Lynne mpegaudiodec_template: disable CRC checking for layers 1 and 2 Layers 1 and 2 use lengths in bits which are not a multiple of 8, an

Re: [FFmpeg-devel] [FFmpeg-cvslog] mpegaudiodec_template: disable CRC checking for layers 1 and 2

On Mon, 3 Aug 2020, Lynne wrote: Aug 3, 2020, 08:58 by mar...@martin.st: This change broke two fate tests; fate-h264-skip-nokey and fate-h264-skip-nointra. The change does look sensible in itself though (framecrcs that used to be all zeros now have nonzero, varying values). Someone must h

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

On Mon, 3 Aug 2020, Michael Niedermayer wrote: On Sun, Aug 02, 2020 at 11:38:51PM +0300, Martin Storsjö wrote: This parameter artificially throttled the generation of the test sample to take 5 seconds. --- tests/fate/hlsenc.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 3/3] test: hlsenc: Use unique init/segment file names for the fmp4_ac3 test

On Sun, 2 Aug 2020, Martin Storsjö wrote: On Sunday, August 2, 2020, Andreas Rheinhardt wrote: Martin Storsjö: > Previously, the hls-fmp4 and hls-fmp4_ac3 tests used the same file > names for init and segment files, which occasionally could

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/cfhd: use LUT for 9 and 18 codebook decompanding

On Mon, 3 Aug 2020, Paul B Mahol wrote: ffmpeg | branch: master | Paul B Mahol | Mon Aug 3 09:33:36 2020 +0200| [05e58ce4e29ea47b2e06888c64055aa2f8d3e76c] | committer: Paul B Mahol avcodec/cfhd: use LUT for 9 and 18 codebook decompanding Also fix codebook 9 decompanding, fixing artifact wit

Re: [FFmpeg-devel] [PATCH 2/5] lavc/libopenh264enc: use framerate if available

On Wed, 5 Aug 2020, myp...@gmail.com wrote: On Sun, Jul 26, 2020 at 8:26 PM Jun Zhao wrote: From: Jun Zhao Respecting the framerate in the libopenh264enc codec context. Both the libx264 and libx264 encoders already contain similar logic to first check the framerate before falling back to t

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

On Mon, 3 Aug 2020, Martin Storsjö wrote: On Mon, 3 Aug 2020, Michael Niedermayer wrote: is this removing the only test which tests the "-re" flag ? if so that would reduce test coverage Well, tehcnically yes, but this test doesn't actually test whether the "-re&q

Re: [FFmpeg-devel] [PATCH v3 2/3] avormat/av1dec: add low-overhead bitstream format

On Thu, 13 Aug 2020, James Almer wrote: On 8/13/2020 3:51 AM, Xu Guangxin wrote: + +ret = obu_prefetch(s, header, MAX_OBU_HEADER_SIZE); +if (!ret) +return AVERROR(EOF); We use AVERROR_EOF rather than AVERROR(EOF) (Afair, it was done because EOF is not portable, but don't quo

Re: [FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

On Thu, 20 Aug 2020, Moritz Barsnick wrote: Add the "http_proxy" option and its handling to the "tls" protocol, pass the option from the "https" protocol. The "https" protocol already defines the "http_proxy" command line option, like the "http" protocol does. The "http" protocol properly honor

Re: [FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

Hej, On Thu, 20 Aug 2020, Moritz Barsnick wrote: Hej Martin, On Thu, Aug 20, 2020 at 22:05:39 +0300, Martin Storsjö wrote: Even if you do e.g. a plain tls socket (or rtmps, or whatever), you may want to do the tls connection through a proxy server (be that a socks proxy or http proxy

Re: [FFmpeg-devel] [PATCH v2] avformat/http, tls: honor http_proxy command line variable for HTTPS

Hej Moritz, On Fri, 21 Aug 2020, Moritz Barsnick wrote: Patch version 2 attached, with added documentation. LGTM, with one small nit: @@ -49,6 +50,7 @@ typedef struct TLSShared { {"cert_file", "Certificate file",offsetof(pstruct, options_field . cert_file), AV_OP

Re: [FFmpeg-devel] [PATCH v3] avformat/http, tls: honor http_proxy command line variable for HTTPS

On Sun, 23 Aug 2020, Moritz Barsnick wrote: Hej igen, On Fri, Aug 21, 2020 at 12:19:06 +0300, Martin Storsjö wrote: LGTM, with one small nit: [...] {"listen", "Listen for incoming connections", offsetof(pstruct, options_field . listen),AV_OPT_TYPE_INT

Re: [FFmpeg-devel] [PATCH 1/3] lavf/sdp: add const qualifiers where appropriate

On Sat, 4 Dec 2021, Anton Khirnov wrote: Declares that these structs are read-only for this code. --- libavformat/internal.h | 2 +- libavformat/rtp.c | 4 ++-- libavformat/rtp.h | 4 ++-- libavformat/sdp.c | 21 +++-- 4 files changed, 16 insertions(+), 15 deletions

Re: [FFmpeg-devel] [PATCH 2/3] lavf/sdp: reindent switch() according to our conventions

On Sat, 4 Dec 2021, Anton Khirnov wrote: --- libavformat/sdp.c | 504 +++--- 1 file changed, 252 insertions(+), 252 deletions(-) Ok // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpe

Re: [FFmpeg-devel] [PATCH 3/3] lavf/sdp: add more thorough error handling

On Sat, 4 Dec 2021, Anton Khirnov wrote: Return error codes when constructing a stream config fails, rather than just disregarding the failure and continuing. Propagate the error codes from av_sdp_create(). --- libavformat/internal.h | 7 +- libavformat/sdp.c | 189

Re: [FFmpeg-devel] [PATCH v2 1/6] avformat/rtsp: remove redundant assignment

On Mon, 6 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index deaed34..47120fd 100644 --- a/libavformat/rtsp.c +++ b/libav

Re: [FFmpeg-devel] [PATCH v2 2/6] avformat/rtsp: free the alloc memory if failed

On Mon, 6 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtsp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 47120fd..5cffe0b 100644 --- a/libavformat/rtsp.c +++ b/libavf

Re: [FFmpeg-devel] [PATCH v2 3/6] avformat/rtsp: use MAX_URL_SIZE for one line parse

On Mon, 6 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang The buf is used for one line of sdp parsing, so it's ok to use MAX_URL_SIZE Signed-off-by: Limin Wang --- libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/

Re: [FFmpeg-devel] [PATCH v2 4/6] avformat/rtsp: check content_ptr before memory allocate

On Mon, 6 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtsp.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 3e4a68a..b3d1e91 100644 --- a/libavformat/rtsp.c +++ b/li

Re: [FFmpeg-devel] [PATCH v2 5/6] avformat/rtsp: add error code handling for ff_rtsp_skip_packet()

On Mon, 6 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtsp.c| 15 ++- libavformat/rtsp.h| 4 +++- libavformat/rtspenc.c | 7 +-- 3 files changed, 18 insertions(+), 8 deletions(-) This should be fine. // Martin __

Re: [FFmpeg-devel] [PATCH v2 6/6] avformat/rtsp: fix the error code from ffurl_read_complete()

On Mon, 6 Dec 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 4ae810d..c591664 100644 --- a/libavformat/rtsp.c +++ b/lib

Re: [FFmpeg-devel] [PATCH 3/3] lavf/sdp: add more thorough error handling

On Tue, 7 Dec 2021, Anton Khirnov wrote: Quoting Martin Storsjö (2021-12-07 10:14:59) On Sat, 4 Dec 2021, Anton Khirnov wrote: > Return error codes when constructing a stream config fails, rather than > just disregarding the failure and continuing. > Propagate the error c

Re: [FFmpeg-devel] [PATCH v3 2/5] build: detect Metal.framework and build .metal files

On Thu, 16 Dec 2021, Aman Karmani wrote: From: Aman Karmani Signed-off-by: Aman Karmani --- .gitignore | 3 +++ configure | 8 +++- ffbuild/common.mak | 9 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 9ed24b542e..1a5b

Re: [FFmpeg-devel] [PATCH] avformat/movenc: fix duration in mdhd box

On Fri, 17 Dec 2021, Zhao Zhili wrote: It's the duration of this media, should not take account of editlist. --- libavformat/movenc.c | 9 +++-- tests/ref/fate/movenc | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 0f912

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: fix duration in mdhd box

On Fri, 17 Dec 2021, Zhao Zhili wrote: mvhd and tkhd present the post-editlist duration, while mdhd should have the pre-editlist duration. Regression since c2424b1f3. --- libavformat/movenc.c | 2 +- tests/ref/fate/movenc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Thanks, this loo

Re: [FFmpeg-devel] [PATCH v3 6/6] lavc/aarch64: add hevc sao band 8x8 tiling

On Tue, 4 Jan 2022, J. Dekker wrote: --bench on AWS Graviton: hevc_sao_band_8x8_8_c: 317.5 hevc_sao_band_8x8_8_neon: 97.5 hevc_sao_band_16x16_8_c: 1115.0 hevc_sao_band_16x16_8_neon: 322.7 hevc_sao_band_32x32_8_c: 4599.2 hevc_sao_band_32x32_8_neon: 1246.2 hevc_sao_band_48x48_8_c: 10021.7 hevc_sa

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc/arm: dont assign hevc_qpel functions for non-multiple of 8 widths

On Wed, 5 Jan 2022, Andreas Rheinhardt wrote: J. Dekker: The assembly is written assuming that the width is a multiple of 8. However the real issue is the functions were errorneously assigned to the 2, 4, 6 & 12 widths. This behaviour never broke the decoder as samples which trigger the functi

[FFmpeg-devel] [PATCH 1/4] Revert "lavc/aarch64: add hevc sao band 8x8 tiling"

This reverts commit f63f9be37c799ddc835af358034630d31fb7db02, as it breaks fate-hevc. --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 +- libavcodec/aarch64/hevcdsp_sao_neon.S | 11 --- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_in

[FFmpeg-devel] [PATCH 3/4] Revert "lavc/aarch64: add hevc sao edge 16x16"

This reverts commit a9214a2ca31c9d54f893c5ac4004a5ff30a08d10, as it breaks fate-hevc. --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 8 +-- libavcodec/aarch64/hevcdsp_sao_neon.S | 65 --- 2 files changed, 2 insertions(+), 71 deletions(-) diff --git a/libavcodec/aarch64/h

[FFmpeg-devel] [PATCH 2/4] Revert "lavc/aarch64: add hevc sao edge 8x8"

This reverts commit c97ffc1a77ccaf901e642bd21ed26aaf75557745, as it breaks fate-hevc. --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 3 -- libavcodec/aarch64/hevcdsp_sao_neon.S | 51 --- 2 files changed, 54 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_init_aarch6

[FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630d31fb7db02, which later was reverted). --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 +- 1 fi

Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

On Wed, 5 Jan 2022, James Almer wrote: On 1/5/2022 5:31 AM, Martin Storsjö wrote: While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630

[FFmpeg-devel] [PATCH] windows: Remove the VS_FFI_FILEFLAGSMASK setting

According to the documentation, the VS_FFI_FILEFLAGSMASK mask consists of all the following flags set: VS_FF_DEBUG, VS_FF_PATCHED, VS_FF_PRERELEASE, VS_FF_PRIVATEBUILD, VS_FF_SPECIALBUILD. The documentation of these fields say e.g. this: VS_FF_PATCHED File has been modified and is not identic

Re: [FFmpeg-devel] [PATCH] windows: Remove the VS_FFI_FILEFLAGSMASK setting

On Wed, 5 Jan 2022, Hendrik Leppkes wrote: On Wed, Jan 5, 2022 at 1:21 PM Martin Storsjö wrote: According to the documentation, the VS_FFI_FILEFLAGSMASK mask consists of all the following flags set: VS_FF_DEBUG, VS_FF_PATCHED, VS_FF_PRERELEASE, VS_FF_PRIVATEBUILD, VS_FF_SPECIALBUILD. The

Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

On Wed, 5 Jan 2022, Martin Storsjö wrote: While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630d31fb7db02, which later was reverted). ---

Re: [FFmpeg-devel] [PATCH 4/4] aarch64: Disable ff_hevc_sao_band_filter_8x8_8_neon out of precaution

On Fri, 7 Jan 2022, Martin Storsjö wrote: On Wed, 5 Jan 2022, Martin Storsjö wrote: While this function on its own passes all of fate-hevc, there's indications that the function might need to handle widths that aren't a multiple of 8 (noted in commit f63f9be37c799ddc835af358034630

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: fix duration in mdhd box

On Mon, 10 Jan 2022, Zhao Zhili wrote: mvhd and tkhd present the post-editlist duration, while mdhd should have the pre-editlist duration. Regression since c2424b1f3. --- v4: fix more fate Pushed this now, and backported it to 5.0 - sorry for the delay. // Martin

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libopenh264enc: support for colorspace and range information

On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index de4b85c..a55bef8 100644 --- a/libav

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang If the version of libopenh264 >= 1.8, we can't configured main profile as expected, below is the testing cli: ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -frames:v 1 test.ts It'll report: [libopenh264 @ 0x

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option

On Thu, 13 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc -frames:v 1 -bsf trace_headers -f null - before the patch: entropy_coding_mode_flag0 = 1 after the patch: entro

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libopenh264enc: support for colorspace and range information

On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index de4b85c..5b5914c 100644 ---

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libopenh264enc: make the profile configuablable correctly

On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote: From: Limin Wang d3a7bdd4ac54349aea9150a234478635d50ebd87 was based on incorrect conclusions because we had missed to set uiProfileIdc. If the version of libopenh264 >= 1.8, we can't configured main profile as expected, below is the testing c

<    4   5   6   7   8   9   10   11   12   13   >